"Dump…" button in debugger eternally grayed out

[obskyr]

PCSX2 version: 1.4.0
Settings preset: Any, even "safest".
System: Seems to occur on both Windows and Linux, at least.

At any and all times, the memory dump option in the memory window of the debugger – both on the R5900 and R3000 tabs – is grayed out and unusable. This occurs both when the game is running and when it's stopped. What's up with that!

This was mentioned in passing in #996, which illuminates the issue a bit: if there's no search feature, and the memory dump feature isn't working, there doesn't seem to be much recourse for searching through memory.

[lightningterror]

I gave it a quick look and looks like that option isn't implemented/doesn't do anything at all.

pcsx2/pcsx2/gui/Debugger/CtrlMemView.cpp

Line 102 in 1f1b68a

menu.Enable(ID_MEMVIEW_DUMP,false);

Maybe we can comment out the gui portion not to show it at all to avoid confusion.

[obskyr]

Ah. I guess someone put that there as a sort of "to do", that never ended up getting implemented. It'd be nice if it could be implemented, but… until it is, I suppose commenting that out would be nicer.

Are there any other options for dumping memory as it stands?

[tadanokojin]

Yeah let's kill it for now.

While I have you here @obskyr how would you expect it to be implemented?
As far as dumping, maybe cheat engine has such a feature?

[obskyr]

I would expect it to open a box that asks you for which address to start dumping at (prefilled with the address you right-clicked on in the memory window), and boxes for either how many bytes to dump, or an upper address bound. Confirm that box, and it'd open a save dialog.

Something like this, but with "dump" instead of "select", and the base selector at the bottom being optional.

I'll check out Cheat Engine; see if it can do that. Thanks for the advice!

[tadanokojin]

Thank you for the input :)

[obskyr]

Hm… It does seem to have that feature, but do you happen to know how to make CE's memory viewer look at PCSX2's virtual memory, and not the memory the emulator itself uses? I figure it's relevant to ask here, seeing as it's currently required to stand in for the dump functionality missing from the emulator.

[tadanokojin]

I don't, sorry. I know addresses are fine when adding to the cheat table but I don't think I've ever messed with memory dumping.

[obskyr]

Hrm. Alright, that limits Cheat Engine's usefulness with PCSX2, then, if you can't have it only look at the emulated memory. I suppose I'll look forward to this feature being implemented sometime!

[RazielZnot]

@obskyr just make savestate and open it as zip in any archiver, inside it you'll see files for each memory area. I often do it myself, surprised that devs didn't give you such advice.

[tadanokojin]

Not all of us know everything about the emulator.

[lightningterror]

Can this be closed since the initial issue has been resolved?

[obskyr]

I suppose! It'd be nice to have the dump functionality, but I suppose that's a feature request and not a bug report.