New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pcsx2 does not honor XDG directories when built against wxwidgets-3 #352
Comments
Which XDG directory/variable? An example will be nice so I can easily test it. |
Sorry for lack of info. My system is Gentoo amd64. When i start pcsx2 compiled against wxwidgets-3 first time start wizard appears. |
Thanks for the info, it would be easier this way to reproduce it ^^ |
Some notes before I forget them. I basically understand the issue but that is quite complex. 1/ IMPLEMENT_APP(Pcsx2App) will instantiate the Pcsx2App objects. Pcsx2App will call wxAppWithHelpers constructor. Which it turns will instantiate an wxTimer object. The issue is that wxTimerObject requires a tray on wx3.0, so it will try to create one. Wx2.8 doesn't have such requirement so wxAppWithHelpers constructor can finish without any issue. But let's get back to wx3.0 case, a trait will be created but with a wxAppWithHelpers base object instead of a Pcsx2App object. In short wxAppWithHelpers::CreateTraits() will be called instead of Pcsx2App::CreateTraits() |
The fix move the Pcsx2AppTraits definition from core to common part. It allows to use it in wxAppWithHelpers::CreateTraits fix issue #352
Could you test commit above? |
WxGTK-3.0 build works ok, thanks |
Works as expected when builded against wxwidgets-2.8
The text was updated successfully, but these errors were encountered: