Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcsx2 does not honor XDG directories when built against wxwidgets-3 #352

Closed
nE0sIghT opened this issue Nov 16, 2014 · 6 comments
Closed
Assignees

Comments

@nE0sIghT
Copy link
Contributor

Works as expected when builded against wxwidgets-2.8

@gregory38
Copy link
Contributor

Which XDG directory/variable? An example will be nice so I can easily test it.

@gregory38 gregory38 self-assigned this Nov 17, 2014
@nE0sIghT
Copy link
Contributor Author

Sorry for lack of info.

My system is Gentoo amd64.
I do not have XDG_CONFIG_HOME variable set
My pcsx2 config is located at ~/.config/pcsx2

When i start pcsx2 compiled against wxwidgets-3 first time start wizard appears.
When i start pcsx2 compiled against wxwidgets-2.8 it normally read config from ~/.config/pcsx2 and no wizard appears

@gregory38
Copy link
Contributor

Thanks for the info, it would be easier this way to reproduce it ^^

@gregory38
Copy link
Contributor

Some notes before I forget them. I basically understand the issue but that is quite complex.

1/ IMPLEMENT_APP(Pcsx2App) will instantiate the Pcsx2App objects.
2/ Because of virtual function, it is expected that the following will be called to create the trait
wxAppTraits* Pcsx2App::CreateTraits()

Pcsx2App will call wxAppWithHelpers constructor. Which it turns will instantiate an wxTimer object.

The issue is that wxTimerObject requires a tray on wx3.0, so it will try to create one. Wx2.8 doesn't have such requirement so wxAppWithHelpers constructor can finish without any issue.

But let's get back to wx3.0 case, a trait will be created but with a wxAppWithHelpers base object instead of a Pcsx2App object. In short wxAppWithHelpers::CreateTraits() will be called instead of Pcsx2App::CreateTraits()

gregory38 added a commit that referenced this issue Nov 22, 2014
The fix move the Pcsx2AppTraits definition from core to common part.
It allows to use it in wxAppWithHelpers::CreateTraits

fix issue #352
@gregory38
Copy link
Contributor

Could you test commit above?

@nE0sIghT
Copy link
Contributor Author

WxGTK-3.0 build works ok, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants