GSdx OpenGL backend does not apply GUI changes on the fly

[bositman]

-PCSX2 version: Any

-PCSX2 options: Defaults, no settings modifications affect the issue

-Description: Using the OpenGL renderer, if you change settings through the plugin configuration while running a game, the settings will not get applied EXCEPT: If you switch to SW and back to HW by pressing F9 twice.

-How to replicate: Boot a game with OpenGL Hardware with 'native' checked. The game will correctly render at native resolution (initial settings load properly). At any time go to the plugin configuration and switch to 6x scaling, press ok. Game will still render at native resolution. Same seems to apply for every GUI option (for example hardware hacks panel)

-Last known version to work: Tested back to r103 ( 2da4a5e ), didn't work anywhere. It probably never worked but we never used OpenGL enough to find it :P Thanks to @mirhl and vsub from the forum for reporting it

-PC specifications: CPU: Intel Core i5 2500K @ 4.3Ghz GPU: Gigabyte Geforce GTX660 Windforce OC 2 GB OS: Windows 7 SP1

[ssakash]

the values are getting changed at the INI file but they are not actually taking effect , sounds like some internal option update problem.

[vsub]

It's not just with OGL...you'll get all all kind of weird results if you use F9 and switch modes from the GSdx settings while a game is running.
For example I can make GSdx to run in hw mode while choosing some SW mode from the settings and the other way around.

[ssakash]

@vsub
That was a valuable information, Thanks for mentioning about this I managed to reproduce this on my side. though I don't know how to fix it up :p anyway, please make an another bug report for this case. Thanks

[gregory38]

Before I forget, it seems related that s_gs is not properly delete/new

[gregory38]

Is it really working on dx side? Could someone made a couple of test for me

Boot in hw mode in 4x scaling
Open the gui and tick the native box
Check visually the rendering, is it native? or upscaled?

Is there any glitch when you change the render in the option?
GL HW => DX HW
GL HW => DX SW
DX SW => GL HW

[ssakash]

It gives the native resolution output on both D3D9 & D3D11 (hardware mode) at your mentioned test. only Opengl still gives me the Upscaled resolution.

no glitches found on render change.

Tested game: Ben10 : protector of earth.

[TheLastRar]

DX 11 mode, Changing scaling takes effect (I went from native to 4x).
OGL mode, Changing scaling did not take effect (from native to 4x, stayed at native).
Changing the render takes affects, no obvious issue.
When I was changing GL HW => DX HW, it applied the change I made in the HW hacks section that OpenGL failed to pick up, going back the GL HW allowed GL mode to apply the changes on its side.

[gregory38]

I made a PR. Please test it carefully savestate/F9 toggling etc...