Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: Replace debugger menu bar with toolbar #10006

Merged
merged 4 commits into from
Sep 23, 2023
Merged

Qt: Replace debugger menu bar with toolbar #10006

merged 4 commits into from
Sep 23, 2023

Conversation

stenzek
Copy link
Member

@stenzek stenzek commented Sep 23, 2023

Description of Changes

Stops the buttons from not being visible with certain themes on Linux, and on MacOS.

Also adds keyboard shortcuts.

Rationale behind Changes

Fixes debugger on MacOS.

Suggested Testing Steps

Test debugger toolbar.

Copy link
Member

@F0bes F0bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows. Everything works, code looks good (I'm glad it most of it can just be put in the ui files 😄)

Copy link
Contributor

@kamfretoz kamfretoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes Buttons disappearing under Linux with weird themes

@stenzek stenzek merged commit 508c209 into PCSX2:master Sep 23, 2023
12 checks passed
@stenzek stenzek deleted the qt branch September 23, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants