ChdFileReader: Rewrite CHD opening #10028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Build | Project System
CDVD
Dependencies
Based on 54bfb87 with modifications from DuckStation.
stenzek
force-pushed
the
chd
branch
5 times, most recently
from
3dd8bc5
to
8d52ac5
Compare
Almost copied verbatim from DuckStation. - Doesn't have race conditions between checking header and opening the file for reading. - Handles both MD5/SHA1 hashes. - Caches CHD headers when searching for parents. - Doesn't break with unicode filenames on Windows.
CookiePLMonster
approved these changes
Sep 26, 2023
JordanTheToaster
approved these changes
Sep 27, 2023
Earthman100
reviewed
Sep 30, 2023
| } | ||
| else if (err != CHDERR_REQUIRES_PARENT) | ||
| { | ||
| Console.Error(fmt::format("Failed to open CHD '{}': {}", filename, chd_error_string(err))); |
There was a problem hiding this comment.
Change chd_error_string to ConsoleOpen2chdFileReader::bool({Console.fmt_err}{)}_filename
There was a problem hiding this comment.
also fix close2 bool(){}<<<disk tray on chdFileReader from fp.release to (insert::return chd) <<<<is C header to Disk at eject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Almost copied verbatim from DuckStation.
We could potentially expose precaching in the future too, though I'm not sure if that makes so much sense for PS2.. lots of RAM needed.
Rationale behind Changes
See above.
Suggested Testing Steps
Test CHDs, both "normal", and parent+child setups. Also multiple levels nesting, i.e. what Silent is doing