GS/TC: Copy only up to old RT size on preload overlap #10409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refractionpcsx2
force-pushed
the
gs_copytargetheight
branch
from
7a98e3f
to
ea2a8f7
Compare
refractionpcsx2
force-pushed
the
gs_copytargetheight
branch
from
ea2a8f7
to
b6b688a
Compare
lightningterror
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Correctly handle the height of copies from old render targets when preloading.
Rationale behind Changes
It was copying too much if the target not only overlapped the old one, but was also much bigger, causing crashes (mainly on DX12)
Suggested Testing Steps
Test hitman contracts, and any other game which crashed on DX12