Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pad: Add Pop'n Music controller type #10534

Merged
merged 1 commit into from Jan 5, 2024
Merged

Conversation

RedPanda4552
Copy link
Sponsor Contributor

Description of Changes

Adds an implementation of the Pop'n Music controller. Yep, that's the whole thing.

Side note: Like with guitars, automatic mapping with this controller type will make no damn sense at all because it isn't a normal gamepad. That is not a bug, that is a consequence of having a unique button layout, and it is up to the user to do it manually if they want mappings that make sense. Get over it.

Rationale behind Changes

Easier for users to set up than trying to guess what DS2 controls they need to map to for a Pop'n controller to make "sense". At least some of the games don't strictly require the Pop'n Music controller, but perhaps others might, so that's another reason.

Suggested Testing Steps

Fire up one of the Pop'n Music games, see if the controller reacts the way you expect it to.

@RedPanda4552
Copy link
Sponsor Contributor Author

As per usual, I am no artist, and I have suppled a scuffed png for the reference image in the mapping screen. Please hold merge until we can get a proper svg for it.

@RedDevilus
Copy link
Contributor

How does this supposed eldritch horror draft of a png look like? ;)

@RedPanda4552
Copy link
Sponsor Contributor Author

Another point of interest is that we do not have font icons directly suitable for these buttons, since they are all circles with solid colors. I went ahead and just used the DS2 button icons which would match the literal bitmask that the Pop'n controller uses.

I am open to changing that, but someone would need to find a way to supply icons which can somehow convey both position and color of the buttons, in a tiny and monochromatic font icon that will render as text at the bottom of the OSD. Not exactly something I think there's a better solution for, but I hope I can be proven wrong on this one.

@github-actions github-actions bot added the Dependencies Pull requests that update a dependency file label Jan 5, 2024
Copy link
Member

@stenzek stenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from a quick glance

@stenzek stenzek merged commit 10389dc into PCSX2:master Jan 5, 2024
12 checks passed
@RedPanda4552 RedPanda4552 deleted the popn-support branch January 5, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build | Project System Dependencies Pull requests that update a dependency file GUI/Qt PAD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants