Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS/HW: Handle offset RTs when offset texture is detected #10543

Merged
merged 2 commits into from Jan 5, 2024

Conversation

stenzek
Copy link
Member

@stenzek stenzek commented Jan 4, 2024

Description of Changes

Catwoman draws to the target at 2E60 via 2D00, one page back horizontally, and one vertically.

The Destroy All Humans fix also works here, but it only applied to the texture, not the RT. So do a very conservative form of RT-in-RT to handle Catwoman.

Also adds round sprite full to fix post-processing alignment when upscaled.

Rationale behind Changes

Closes #10542.

Before:
image

After:
image

Suggested Testing Steps

Test Catwoman.

Catwoman draws to the target at 2E60 via 2D00, one page back
horizontally, and one vertically.

The Destroy All Humans fix also works here, but it only applied to the
texture, not the RT. So do a very conservative form of RT-in-RT to
handle Catwoman.

Unfortunately nothing else benefits from it.
@stenzek stenzek merged commit 5e191a6 into PCSX2:master Jan 5, 2024
13 checks passed
@stenzek stenzek deleted the catwoman branch January 5, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Catwoman misaligned bloom
3 participants