Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PINE: fix regressions introduced in #10448 #10584

Merged
merged 1 commit into from
Jan 8, 2024
Merged

PINE: fix regressions introduced in #10448 #10584

merged 1 commit into from
Jan 8, 2024

Conversation

GovanifY
Copy link
Member

@GovanifY GovanifY commented Jan 8, 2024 •
edited

Description of Changes

PR #10448 introduced two regressions to PINE:

  • Inverted the OOB checks, causing it to return that a packet is unsafe when within bounds
  • Used the incorrect type for socket binding, leading to the socket never binding on Windows.

This fixes both regressions

Rationale behind Changes

PINE was broken

Suggested Testing Steps

Well a bit late but compile and run the sample client from here: https://projects.govanify.com/govanify/pine

This fixes #10582

@Mrlinkwii Mrlinkwii mentioned this pull request Jan 8, 2024
Closed
refractionpcsx2
refractionpcsx2 reviewed Jan 8, 2024
View reviewed changes
pcsx2/PINE.h Outdated Show resolved Hide resolved
@refractionpcsx2 refractionpcsx2 merged commit 72787d1 into master Jan 8, 2024
22 checks passed
@refractionpcsx2 refractionpcsx2 deleted the pine-regression branch January 8, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refractionpcsx2 refractionpcsx2 refractionpcsx2 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: PINE stopped working
2 participants
@GovanifY @refractionpcsx2