GS/HW: Don't bother trying to draw empty draws #10591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanTheToaster
approved these changes
Jan 11, 2024
Mrlinkwii
approved these changes
Jan 11, 2024
kamfretoz
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Skips drawing empty rect draws.
Rationale behind Changes
This doesn't actually draw anything, but just makes weird targets with bad information (the Dark Cloud example had a start BP of 0x1A40 and end of 0x1A3F because of how it's calculated).
Suggested Testing Steps
Test random games, a bunch of stuff showed up in a GS dump (probably due to lack of resizing), try Dark Cloud.
Dark Cloud
Master:
PR: