GS/HW: Better avoid target uploads on HW clear #10683
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Noticed COD was uploading its depth buffer that it just cleared, which was all zeros.
Previous heuristic made sure it was the previous draw that cleared it, to skip the upload. But when you draw other stuff inbetween the clear and the first draw that uses the target (like cod does with its skybox), that doesn't work.
So, make the hw_clear a flag instead, so that later partial writes don't get lost to full-target writes.
Rationale behind Changes
Fewer target uploads. Vroom vroom
Suggested Testing Steps
Smoke test, check some affected games like NFSU, God Hand, God of War.