Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS/HW: Better avoid target uploads on HW clear #10683

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Conversation

stenzek
Copy link
Member

@stenzek stenzek commented Jan 20, 2024

Description of Changes

Noticed COD was uploading its depth buffer that it just cleared, which was all zeros.

Previous heuristic made sure it was the previous draw that cleared it, to skip the upload. But when you draw other stuff inbetween the clear and the first draw that uses the target (like cod does with its skybox), that doesn't work.

So, make the hw_clear a flag instead, so that later partial writes don't get lost to full-target writes.

Rationale behind Changes

Fewer target uploads. Vroom vroom

Suggested Testing Steps

Smoke test, check some affected games like NFSU, God Hand, God of War.

@stenzek stenzek merged commit 3b25fa3 into PCSX2:master Jan 20, 2024
12 checks passed
@stenzek stenzek deleted the upload branch January 20, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants