GS/HW: Check both edges of current triangle for quads #10967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Checks both edges of the current triangle during quad check
Rationale behind Changes
When using DX and VK they can have different settings for "provoking vertex", meaning the first and last point can be swapped, this was causing the quad check to fail as the first vert wasn't connected to the previous triangle. In Transformers on DX, this meant that it ended up using an image from a previous draw as depth.
Suggested Testing Steps
Smoke test mostly.
Fixes in Vulkan
Splinter Cell - Chaos Theory:
Master:
PR:
Fixes in Direct3D11
Transformers:
Master:
PR: