Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS/HW: Detect shuffles reshaping the target #10968

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

refractionpcsx2
Copy link
Member

@refractionpcsx2 refractionpcsx2 commented Mar 24, 2024

Description of Changes

Detect when the width of a shuffle isn't a multiple of the original texture size and handle resized shuffles.

Rationale behind Changes

Superman Shadow of Apokolips does a shuffle where it decides to do 1024x529 instead of 640x448 which is the original screen size, so this isn't double in either direction which shuffles normally are (because this is done in 16bit on a 32bit target)

Suggested Testing Steps

Smoke test and Superman,.
Fixes #10908

Master:
image
PR:
image

Copy link
Contributor

@lightningterror lightningterror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superman dumps work fine.

@refractionpcsx2 refractionpcsx2 merged commit d6e3ecc into master Mar 26, 2024
22 checks passed
@refractionpcsx2 refractionpcsx2 deleted the gs_reshapeshuffle branch March 26, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Broken shuffle effect on superman shadow of apokolips
4 participants