GS/HW: Round lookup rect to block boundary and improve overlap check. Fix up shuffle behaviour (Mostly Direct3D)

[refractionpcsx2]

Description of Changes

Round up lookup rects to the ceiling block, but without the TextureMinMax adjustment. Also clean up the Tex in RT check and general formatting in the texture cache file.

Also fix up some shuffle behaviour to fix some issues when the texture can't be the framebuffer (like no barriers)

Rationale behind Changes

This is one thing that's been a bit of a bane for us, the cleaning up was just something I wanted to do.
Shuffles had problems with copying the framebuffer correctly and setting the coordinates/copy area, this fixes that up.

Suggested Testing Steps

Test many games, especially ones which use Tex in RT, make sure they're no worse.

Fixes Godfather (for reals)
Also fixes Godfather and 007 Russia With Love on Direct3D and probably Metal too.
Corrects the minimap on Steambot and PachiPara 13

Vulkan Comparisons:

Godfather:
Master:

PR:

Agnostic Comparisons:

PachiPara 13:
Master:

PR:

Steambot:
Master:

PR:

D3D Comparisons:

007 Russia With Love:
Master:

PR:

Ace Combat 04 (Clouds):
Master:

PR:

Ace Combat 04 (Shadows):
Master:

PR:

Armored Core - Last Raven:
Master:

PR:

Scarface (Left edge):
Master:

PR;

[TheTechnician27]

Confirmed fixes Godfather. Black line during cutscenes is gone, and I cannot reproduce the reflecting pool after more than 20 minutes of gameplay, when previously the glitch would activate if you looked at the game funny.

[refractionpcsx2]

I've gone and done some further changes, I spent some time making Godfather and 007 work in Direct3D and fixed some bugs while I was at it, and it nicely fixed a few other things, candy shots above.

Enjoy!

[coornio]

Seeing the changes in the minimap of some of these games, any chance this also concerns the minimap of Persona 4 too? Admittedly it's been a while since I tested anything so if that was tackled already, please ignore me :P

[refractionpcsx2]

Seeing the changes in the minimap of some of these games, any chance this also concerns the minimap of Persona 4 too? Admittedly it's been a while since I tested anything so if that was tackled already, please ignore me :P

Persona 4 is fixed in software, that's due to how the coordinates translate on to the screen, GPU's do things differently. I don't know if I can fix that at all.