DEV9: TCP Cleanup #11132
Merged
DEV9: TCP Cleanup #11132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is UB, but is required by the api
TheLastRar
force-pushed
the
DEV9-TcpCleanup
branch
from
10ed3d8
to
b64a07c
Compare
|
Socket servers still work on linux!
Emulog for reference: |
AmyRoxwell
approved these changes
Apr 27, 2024
kamfretoz
approved these changes
Apr 28, 2024
Mrlinkwii
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Replace C-Style casts with C++ equivalents.
Make capitalisation of text in log messages consistent.
Format comments to (hopefully) be more inline with PCSX2's comment style
Fix incorrect error check on TCP send
Add a few missing const
It may be easier to review each commit one by one rather than the whole pr at once
Rationale behind Changes
Improve code quality
Fix a broken error check
Suggested Testing Steps
Test networked games using the sockets backend.