Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameDB: fix tearing like issues on KH2 when upscaled #11266

Merged
merged 1 commit into from
May 19, 2024

Conversation

GovanifY
Copy link
Member

Description of Changes

Switches KH2 roundSprite mode to half to fix a graphical upscaling artifact.

Rationale behind Changes

#11265 reported tearing-like issues that didn't seem to happen in previous revisions when upscaling KH2. Bisecting led me to #7545 , which fixes other upscaling issues with KH2, but also introduces this graphical bug.

Switching roundSprite to half seems to fix the bug while not introducing other obvious ones (eg, Mulan's cutscene as shown in @JordanTheToaster 's PR works fine under half mode.

Suggested Testing Steps

See if anything in KH2 breaks pretty much, as I didn't see any discussion as to why we used full rounding in the past, this might break something I'm unaware of. Nevertheless opening this PR to at least talk about it.

@Xaddgx-Absol-Brasse
Copy link

Here are comparison shots of Round Sprite between 2 and 1. 2 Introduces subtle line tearing on upscaling, whereas 1 does not. Here are screenshots with distance, and also zoomed in. You can see a line going down the eye more clearly when it's zoomed in, but it extends all the way down beyond. Also included a screenshot of the same Mulan cutscene on Round Sprite 1 just to show it doesn't reintroduce the issue of floor problems. For the eye shots, feel free to zoom in closer with ctrl+mouse wheel if needed, I did the best I could.
https://imgur.com/a/zmZnSMt

@bigol83
Copy link

bigol83 commented May 18, 2024

Ok, i zoomed in and took a screenshot so it is much more visible

Round Sprite 1 (Half)
rs1

Round Sprite 2 (Full)
rs2

@Xaddgx-Absol-Brasse
Copy link

1 Round Sprite appears to offset emanating glows from where they should be when upscaled. The higher the upscale, the more offset it becomes.
https://imgur.com/a/2kayz6P

@bigol83
Copy link

bigol83 commented May 18, 2024

1 Round Sprite appears to offset emanating glows from where they should be when upscaled. The higher the upscale, the more offset it becomes. https://imgur.com/a/2kayz6P

So yeah, even if introduces that line it seems like in general Round Sprite 2 (full) is better for upscaling.

@JordanTheToaster
Copy link
Contributor

Changing the HPO from Special to Align to Native to better align the bloom in the world as well as changing back to round sprite half to fix aforementioned issues.

Before:
image

After:
image

@refractionpcsx2 refractionpcsx2 merged commit 39a493f into master May 19, 2024
23 of 24 checks passed
@refractionpcsx2 refractionpcsx2 deleted the kh2tearing branch May 19, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants