Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: blacklist GCC 7.0 and GCC 7.1 #1949

Merged
merged 1 commit into from Jun 29, 2017
Merged

cmake: blacklist GCC 7.0 and GCC 7.1 #1949

merged 1 commit into from Jun 29, 2017

Conversation

gregory38
Copy link
Contributor

@gregory38 gregory38 added this to the Release 1.6 milestone May 21, 2017
turtleli
turtleli reviewed May 22, 2017
View reviewed changes
cmake/Pcsx2Utils.cmake Outdated
@@ -70,6 +70,11 @@ function(check_compiler_version version_warn version_err)
endif()
endif()

if(GCC_VERSION VERSION_EQUAL "7.0" OR GCC_VERSION VERSION_EQUAL "7.1")
message(FATAL_ERROR "GCC 7.0/7.1 generates invalid code => https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80799\n"
"You can either backport the fix or swith to another version of GCC.")

This comment was marked as spam.

Sign in to view

This comment has been minimized.

Sign in to view

This comment was marked as spam.

Sign in to view

@gregory38
Copy link
Contributor Author

@orbea I added a small testcase to ensure GCC correctness. Could you confirm me that it is able to detect the gcc bug. Thank you.

@orbea

This comment has been minimized.

Sign in to view
@gregory38
Copy link
Contributor Author

@orbea I moved the code to avoid order issue. Could you test it again? Thanks you

@orbea

This comment has been minimized.

Sign in to view
@gregory38
Copy link
Contributor Author

@orbea does the patch detect bad GCC ? I.e abort in Cmake because GCC doesn't work as expected.

@orbea

This comment has been minimized.

Sign in to view
@gregory38
Copy link
Contributor Author

I made some improvements. I hope it will be enough. Otherwise I will need your help to get the generated binary to understand what is generated/what is happening.

Operation to get the binary

  • add --debug-trycompile option
  • use Cmake directly (not build.sh, otherwise you need to disable ninja)
  • Get the binary name from build_dev/CMakeFiles/CMakeTmp/Makefile
  • If you're lucky grep -o "cmTC_\w*" build_dev/CMakeFiles/CMakeTmp/Makefile | uniq
  • Send me the binary (example: build_dev/CMakeFiles/CMakeTmp/cmTC_8dad8)

@orbea

This comment has been minimized.

Sign in to view
@orbea

This comment has been minimized.

Sign in to view
@gregory38 gregory38 merged commit 7d75a73 into master Jun 29, 2017
@gregory38
Copy link
Contributor Author

@orbea thanks you for all the tests 👍

@gregory38 gregory38 deleted the greg/blacklist-bad-gcc branch July 2, 2017 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orbea orbea orbea left review comments

@turtleli turtleli turtleli left review comments

Assignees
No one assigned
Labels
GS OS: Linux
Projects
None yet
Milestone
Release 1.6
Development

Successfully merging this pull request may close these issues.

GSDX non-functional with gcc-7.1.0
3 participants
@gregory38 @orbea @turtleli