Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameDB: Patch update and EETimingHack fix for Drakan 2 demo and Ruff Trigger #2332

Merged
merged 1 commit into from Mar 20, 2018
Merged

Conversation

ghost
Copy link

@ghost ghost commented Mar 2, 2018

I update some patch file and add missing EETimingHack to Drakan 2 demo and Ruff Trigger.
Tekken 4 patches will be remove when the @FlatOutPS2 IPU PR will be available.

Close: #1496

@ghost ghost changed the title GameDB: Patch update, VU/EE useless clamp mode and EETimingHack fix for Drakan 2 demo GameDB: Patch update, VU/EE useless clamp mode and EETimingHack fix for Drakan 2 demo and Ruff Trigger Mar 2, 2018
@@ -4688,6 +4672,7 @@ Compat = 5
Serial = SCUS-97169
Name = Drakan - The Ancients' Gates [Demo] // aka "Drakan 2 [Demo]"

This comment was marked as spam.

@@ -11632,6 +11638,14 @@ Serial = SLES-52440
Name = Harry Potter and the Prisoner of Azkaban
Region = PAL-M7
Compat = 3
//[patches = 51E019BC]
// //prafull's highly experimental patch.

This comment was marked as spam.

patch=1,EE,003ccbb4,word,01ce7026
patch=1,EE,003ccbb8,word,19a00011
[/patches]
//[patches = cbbc2e7f]

This comment was marked as spam.

patch=1,EE,002aa934,word,00000000
patch=1,EE,002aa574,word,00000000
[/patches]
//[patches = 80802EA9]

This comment was marked as spam.

@FlatOutPS2
Copy link
Contributor

I update some patch file, remove VU/EE clamp mode = 1 (they are useless because it's the default configuration)

Don't those fixes override the user Emulation Settings, to prevent a user from accidentally screwing up because they changed the setting for another game?

@FlatOutPS2
Copy link
Contributor

You didn't remove the Drakan PAL GSdx Hardware patch here. Please remove that as well.

@ghost
Copy link
Author

ghost commented Mar 2, 2018

All is fixed now, I also reintroduce clamp mode = 1 after some reflections.

@ghost ghost changed the title GameDB: Patch update, VU/EE useless clamp mode and EETimingHack fix for Drakan 2 demo and Ruff Trigger GameDB: Patch update and EETimingHack fix for Drakan 2 demo and Ruff Trigger Mar 2, 2018
patch=1,EE,002aa934,word,00000000
patch=1,EE,002aa574,word,00000000
comment= Patch By Prafull
fix hang at loading screen

This comment was marked as spam.

@@ -4522,7 +4525,7 @@ Name = Kiosk Demo Disc 2.02
Region = NTSC-U
---------------------------------------------
Serial = SCUS-97128
Name = Drakan - The Ancients' Gates // aka "Drakan 2"
Name = Drakan - The Ancients' Gates
Region = NTSC-U
Compat = 5
EETimingHack = 1 // flickery textures

This comment was marked as spam.

Region = NTSC-U
EETimingHack = 1 // flickery textures

This comment was marked as spam.

@@ -4653,7 +4656,7 @@ Serial = SCUS-97159
Name = Ico [Demo]
Region = NTSC-U
Compat = 5
eeClampMode = 2 // Otherwise freezes in various spots, check full intro
eeClampMode = 2 // Otherwise freezes in various spots, check full intro.
vuClampMode = 1 // Otherwise camera gets stuck off the player in various spots.

This comment was marked as spam.

@@ -7327,6 +7331,11 @@ Compat = 5
Serial = SLES-50355
Name = Batman Vengeance
Region = PAL-M6
[patches = A6F234C7]
comment=patched by Prafull
//Fixes the hang in certain scenarios.

This comment was marked as spam.

@@ -7638,6 +7647,14 @@ Compat = 5
Serial = SLES-50503
Name = Weakest Link
Region = PAL-E
[patches = 7193F81D]
comment=patched by Prafull
//quick fix to hang problem at start.

This comment was marked as spam.

@@ -12344,6 +12369,11 @@ Compat = 5
Serial = SLES-52711
Name = Titeuf Mega Compet
Region = PAL-F
[patches = 958E5086]
comment= patched by Prafull
//Sheep screen freeze fix

This comment was marked as spam.

Region = PAL-E
[patches = D5D1D002]
comment=patch by Prafull
//Fix the initial hang and make the game playable

This comment was marked as spam.

Name = Harry Potter to Himitsu no Heya(Coca Cola Original version)
Region = NTSC-J
[patches = E90BE9F8]
//prafull's patch to make the game work

This comment was marked as spam.

@@ -26628,6 +26672,11 @@ Region = NTSC-J
Serial = SLPM-66497
Name = Ice Age 2
Region = NTSC-J
[patches = 33DB9037]
//Intro screen freeze fix

This comment was marked as spam.

@@ -24867,6 +24906,11 @@ Region = NTSC-J
Serial = SLPM-66008
Name = Musashiden II - Blademaster
Region = NTSC-J
[patches = F0E90890]
comment=patched by Prafull
//Gets rid of some effects, should be ok to pass unplayable areas

This comment was marked as spam.

@@ -1443,22 +1443,6 @@ Serial = SCES-50878
Name = Tekken 4
Region = PAL-M5
Compat = 5
[patches = 2251E14D]

This comment was marked as spam.

// fix hang at loading screen
patch=1,EE,002aa934,word,00000000
patch=1,EE,002aa574,word,00000000
comment= Patch By Prafull

This comment was marked as spam.

@@ -35300,7 +35413,7 @@ Serial = SLUS-20328
Name = Tekken 4
Region = NTSC-U
Compat = 5
[patches = 833FE0A4]
[patches = 833FE0A4]

This comment was marked as spam.

@FlatOutPS2
Copy link
Contributor

Other changes that should be done before merging:

  • Clean up all new // comments by starting with a capital letter and ending with a point.
  • Making sure all new comment= lines follow the same style.

@@ -36853,6 +36977,13 @@ Name = Mafia
Region = NTSC-U
Compat = 4
EETimingHack = 1
[patches = B67F4F9E]
//Patched by Prafull

This comment was marked as spam.

@tony971
Copy link

tony971 commented Mar 3, 2018

I've been following the "Fixing Unplayable Games" thread in the forums, looking for USA game patches and noticed a few that are missing from this pull.

Harvest Moon - A Wonderful Life [SLUS 21171] (U) - 304c115c.pnach

https://forums.pcsx2.net/Thread-Fixing-unplayable-games?pid=531410&highlight=SLUS+21171#pid531410

Major League Baseball 2K5 - World Series Edition [SLUS-21324] (U) - d592b291.pnach

https://forums.pcsx2.net/Thread-Fixing-unplayable-games?pid=528120&highlight=SLUS-21324#pid528120

And last, but certainly the most mysterious, is this one:
ESPN-College Hoops 2K5 [SLUS 20922] (U) - 2b54d3e5.pnach

It seems to have disappeared from the thread entirely, but the patch reads as follows:

gametitle=ESPN-College Hoops 2K5[SLUS 20922] (U)
comment=patch by Prafull
//avoid hang at loading
patch=1,EE,003bcc08,word,00000000

EETimingHack = 1 // Needed to going ingame
[patches = f73488d5]
comment=Patch by Prafull
//quick freeze fix

This comment was marked as spam.

comment=Patch by Prafull
// Fix hang at loading screen.
patch=1,EE,0010f3e0,word,00000000
comment= this disc has the same crc as SLES-52895.

This comment was marked as spam.

Region = PAL-M5
Compat = 5
EETimingHack = 1 // flickery textures
EETimingHack = 1 // flickery textures

This comment was marked as spam.

@@ -35994,9 +36107,9 @@ Region = NTSC-U
Compat = 5
[patches = B0AE1898]

comment=patched by prafull
comment=Patch by Prafull

This comment was marked as spam.

patch=0,EE,002b4c44,word,24060000
patch=0,EE,002b4dc0,word,10000014
comment=Patch by Prafull
// Some missing sounds.

This comment was marked as spam.

@@ -24867,6 +24935,11 @@ Region = NTSC-J
Serial = SLPM-66008
Name = Musashiden II - Blademaster
Region = NTSC-J
[patches = F0E90890]
comment=Patch by Prafull
// Gets rid of some effects, should be ok to pass unplayable areas.

This comment was marked as spam.

@ghost
Copy link
Author

ghost commented Mar 4, 2018

Done. I have just a question about Syphon Filter - The Omega Strain flashlight issue and Musashiden II (aka Musashi Samurai Legend) broken graphics, the GIF FIFO gamefix don't do anything?

@MrCK1
Copy link
Member

MrCK1 commented Mar 4, 2018

You won't necessarily see a visual representation of the GIF FIFO "doing something" in every game. Some games will see no difference in how it runs, others will corrupt textures or cause a hang ect. If it doesn't fix anything in the game, it probably isn't used in the hardware.

@ghost
Copy link
Author

ghost commented Mar 4, 2018

@MrCK1, I was just curious to know if the problem does not come from the GIF FIFO.

@MrCK1
Copy link
Member

MrCK1 commented Mar 4, 2018

It's hard to say unless you try it out yourself. The fact that the hack fixes everything in Spongebob is just sheer luck 😛

patch=0,EE,002b4c44,word,24060000
patch=0,EE,002b4dc0,word,10000014
comment=Patch by Prafull
// This patch cause some missing sounds issues.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@@ -24867,6 +24935,11 @@ Region = NTSC-J
Serial = SLPM-66008
Name = Musashiden II - Blademaster
Region = NTSC-J
[patches = F0E90890]
comment=Patch by Prafull
// Gets rid of some busy effects that cause the screen to flash rapidly, should be ok to pass unplayable areas.

This comment was marked as spam.

This comment was marked as spam.

@@ -30245,12 +30353,12 @@ Name = Dead or Alive 2
Region = NTSC-J
Compat = 5
[patches = 7894BA09]
// change TLSNDDRV RPC to blocking, better would be to move the wait to the top of the function
// Change TLSNDDRV RPC to blocking, better would be to move the wait to the top of the function.
patch=0,EE,00290408,word,24060000

//patch=0,EE,0029055C,word,10000013

This comment was marked as spam.

//dvd version
// change TLSNDDRV RPC to blocking, better would be to move the wait to the top of the function
// dvd version.
// Change TLSNDDRV RPC to blocking, better would be to move the wait to the top of the function.
patch=0,EE,002b06ec,word,24060000

This comment was marked as spam.

//cd version
// change TLSNDDRV RPC to blocking, better would be to move the wait to the top of the function
// Cd version.
// Change TLSNDDRV RPC to blocking, better would be to move the wait to the top of the function.
patch=0,EE,002b06ec,word,24060000

This comment was marked as spam.

patch=0,EE,002b4c44,word,24060000
patch=0,EE,002b4dc0,word,10000014
comment=Patch by Prafull
// Fix game hanging but skips some sounds.

This comment was marked as spam.

@lightningterror
Copy link
Contributor

Commit name:
GameDB: Updates
Commit message:
Removed patches for Drakan - The Ancients' Gates,
it is no longer needed.
Added patch for Yoake no Mariko 2nd Act,
fixes initial hang.
Code reformatting, cleaned up comments/whitespaces.

You can add the other games that have patches added/removed, it's better to know what was changed.

Copy link
Contributor

@lightningterror lightningterror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. I think that's all, unless I missed something.

@pgert
Copy link
Contributor

pgert commented Mar 10, 2018

The patches for Drakan 2 has never been needed - they just remove some display-crap under GSdx-HW. Furthermore, they patches only partially function with some resolution-settings - I wasn't able to come up with a fully universal fix. The display-crap is still there though, so the patches are still of use. I'm guessing that FlatOut reacted on that he found them to be misplaced in GameIndex, so a better description of the alteration might be "Removed display-patches for Drakan - The Ancients' Gates, since they aren't critical."

PS: The patches are still in the WS-pnach, and enabled by default (even though there're kinda misplaced there too).

@FlatOutPS2
Copy link
Contributor

FlatOutPS2 commented Mar 10, 2018

The patches for Drakan 2 has never been needed - they just remove some display-crap under GSdx-HW. Furthermore, they patches only partially function with some resolution-settings - I wasn't able to come up with a fully universal fix. The display-crap is still there though, so the patches are still of use. I'm guessing that FlatOut reacted on that he found them to be misplaced in GameIndex, so a better description of the alteration might be "Removed display-patches for Drakan - The Ancients' Gates, since they aren't critical."

A hack like that isn't only active for the Hardware renderer, it also affects the software renderer and it might hide or cause any other issue in the game we would assume was GSdx related, but was actually caused by this out of place hack. The description should be Removed display-patches for Drakan - The Ancients' Gates, out of place hack for a hardware renderer issue.

If it's also in the WS archive, it should be removed from that as well.

@lightningterror
Copy link
Contributor

If it's also in the WS archive, it should be removed from that as well.

@pgert updated the patches on the WS patches thread.

The description should be Removed display-patches for Drakan - The Ancients' Gates, out of place hack for a hardware renderer issue.

@atomic83GitHub can you update that small detail ? Otherwise this is ready for a merge.

-Removed patches for Drakan - The Ancients' Gates, out of place hack for a hardware renderer issue.
-Added patch for Yoake no Mariko 2nd Act, fixes initial hang.
-Added patch for Batman Vengeance (PAL), fixes hang in certain scenarios.
-Added patch for Weakest Link, fixes game hanging at start.
-Added patch for Crashed, fixes hang at start and ingame.
-Added patch for Titeuf Mega Compet, fixes Sheep screen freeze.
-Added patch for The Spiderwick Chronicles, fixes hang at boot.
-Added patch for Drift Champ, fixes the hang at start of chapter 2.
-Added patch for Ice Age 2 (NTSC-J), fixes intro screen freeze.
-Added patch for Harry Potter and The Chamber of Secrets (NTSC-U - NTSC-J), fixes initial/ingame hang, flickering graphics and speed up loading.
-Added patch for Mafia (NTSC-U), fixes hang before molotov party and a crash in The priest mission.
-Added patch for ESPN - College Hoops 2K5, fixes hang at loading.
-Added patch for Harvest Moon - A Wonderful Life [Special Edition], fixes hang at shipping shed.
-Added patch and EE Timing Hack for Ruff Trigger - Vancore Conspiracy, fixes ingame freeze.
-Added patch for Major League Baseball 2K5 [World Series Edition], fixes hang at start.
-Code reformatting, cleaned up comments/whitespaces.
[skip ci]
@@ -34191,22 +34297,20 @@ Name = Dead or Alive 2
Region = NTSC-U
Compat = 5
[patches = 23AF6876]
//dvd version
// change TLSNDDRV RPC to blocking, better would be to move the wait to the top of the function
// Dvd version.

This comment was marked as spam.

@lightningterror
Copy link
Contributor

@refractionpcsx2 I leave the merging and all those goodies to you.

@refractionpcsx2
Copy link
Member

Thanks :p

@refractionpcsx2 refractionpcsx2 merged commit 1f0de9a into PCSX2:master Mar 20, 2018
@avih
Copy link
Contributor

avih commented Aug 29, 2018

#2570 suggests that many of the patches in this commit don't actually do anything.

Did anyone verify that the patches actually work in PCSX2 from the DB file?

@ghost ghost deleted the Patches-fix branch April 9, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants