New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSdx: Add CRC ids, adjust CRC hacks for Final Fight Streetwise #2343

Merged
merged 2 commits into from Mar 22, 2018

Conversation

Projects
None yet
4 participants
@lightningterror
Member

lightningterror commented Mar 18, 2018

GSdx: Add some missing crc ids.
Sly 2 E3 Demo US, Sly 2 JP.

GSdx Adjust/Replace crc hack for Final Fight Streetwise.
Replace/remove an old crc hack that was used to fix the red vertical
lines issue, the hack is no longer needed. The new hack removes depth
effects on D3D only.
Note: The game has another vertical lines issue that can be fixed with
texture shuffle on D3D.

Add comments to Simple2000Vol114 explaining what the hacks do.

lightningterror added some commits Mar 18, 2018

GSdx: Add some missing crc ids.
Sly 2 E3 Demo US, Sly 2 JP.
GSdx Adjust/Replace crc hack for Final Fight Streetwise.
Replace/remove an old crc hack that was used to fix the red vertical
lines issue, the hack is no longer needed. The new hack removes depth
effects on D3D only.
Note: The game has another vertical lines issue that can be fixed with
texture shuffle on D3D.

Add comments to Simple2000Vol114 explaining what the hacks do.
@lightningterror

This comment has been minimized.

Member

lightningterror commented Mar 20, 2018

@turtleli do you wanna take care of this ? Akash is gonna be busy for a while.

@gregory38

This comment has been minimized.

Contributor

gregory38 commented Mar 22, 2018

So you will still need the new hack with your new PR for texture shuffle ?

@lightningterror

This comment has been minimized.

Member

lightningterror commented Mar 22, 2018

Yea this is a depth hack, removes a transparent wall in front of the player (improper depth).

The old hack was used to remove the vertical red lines but it was useless even before my pr because it got fixed, it had no effect on the texture shuffle problem vertical lines.

@gregory38 gregory38 merged commit 2ad5db2 into PCSX2:master Mar 22, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gregory38

This comment has been minimized.

Contributor

gregory38 commented Mar 22, 2018

Ok. I merged it.

@lightningterror lightningterror deleted the lightningterror:crc-hacksagain branch Mar 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment