GSdx: Don't modify the Y offset value when feedback write is enabled #2991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Fixes the frame output height when viewing security cameras in The Suffering series. The output height is now reported correctly as 640x448 instead of 640x494 in the title bar as well.
|
What is the status on this? |
|
It is a hack, so it will not get merged |
|
Maybe make a report of it in the issue tracker if you're not planning on working on it? |
|
Or reopen the pull request to show that you're trying to find a solution so potential duplicate work is avoided. |
|
I guess you're right, I'll leave it for now. Don't merge this obviously :P |
|
|
|
Xenosaga dream sequence looks good on my end. |
|
As discussed on discord, closing this one since it is a hack. Someone can implement a better alternative in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the frame output height when viewing security cameras in The Suffering series.
The output height is now reported correctly as 640x448 instead of 640x494 in the title bar as well.
Master: (HW)
PR: (HW - ignore flickering, it's another bug with output blending)
Master: (SW)
PR: (SW)
