New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSdx-hw: New SW sprite render function, used in Jak games #3001
Merged
lightningterror
merged 1 commit into
PCSX2:master
from
iMineLink:gsdx-oi-hack-jak-games
Jul 12, 2019
Merged
GSdx-hw: New SW sprite render function, used in Jak games #3001
lightningterror
merged 1 commit into
PCSX2:master
from
iMineLink:gsdx-oi-hack-jak-games
Jul 12, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMineLink
force-pushed
the
gsdx-oi-hack-jak-games
branch
from
June 29, 2019 11:44
ad81719
to
bc62f0a
Compare
iMineLink
force-pushed
the
gsdx-oi-hack-jak-games
branch
from
July 6, 2019 05:53
ede7b7b
to
542e869
Compare
iMineLink
referenced
this pull request
in iMineLink/pcsx2
Jul 6, 2019
Fixes Jak and Daxter colors in Jak games (old hack yielded wrong colors and clashed with texture in RT TC hack) - Remove OO_JakGames hack for palette readback from framebuffer (slow, clashes with texture in RT TC hack, clashes with Target readback logic) - Add OI_JakGames hack for CPU palette rendering (fast, does not clash with texture in RT TC hack, no readback required) - Extracted CPU rendering logic into dedicated method SwSpriteRender
iMineLink
force-pushed
the
gsdx-oi-hack-jak-games
branch
4 times, most recently
from
July 11, 2019 17:52
ae90f3d
to
eba540d
Compare
iMineLink
changed the title
GSRendererHW: Jak games OI hack CPU palette render
GSRendererHW: New SW sprite render function, used in Jak games
Jul 11, 2019
iMineLink
force-pushed
the
gsdx-oi-hack-jak-games
branch
from
July 11, 2019 21:35
eba540d
to
c556d14
Compare
Developed a new SW sprite render function, which is used to fix Jak and Daxter colors in Jak games and to remove the old Jak games hack which yielded wrong colors and clashed with TC search texture in RT function. - Remove OO_JakGames hack for palette readback from framebuffer (slow, clashes with texture in RT TC function, clashes with Target readback logic) - Developed new method SwSpriteRender with CPU rendering logic - Add OI_JakGames method using SwSpriteRender for CPU palette rendering (fast, does not clash with texture in RT TC function, no readback required)
iMineLink
force-pushed
the
gsdx-oi-hack-jak-games
branch
from
July 11, 2019 21:42
c556d14
to
370e4e6
Compare
lightningterror
changed the title
GSRendererHW: New SW sprite render function, used in Jak games
GSdx-hw: New SW sprite render function, used in Jak games
Jul 12, 2019
JibbityJobbity
pushed a commit
to JibbityJobbity/pcsx2
that referenced
this pull request
Jul 14, 2019
…X2#3001) Developed a new SW sprite render function, which is used to fix Jak and Daxter colors in Jak games and to remove the old Jak games hack which yielded wrong colors and clashed with TC search texture in RT function. - Remove OO_JakGames hack for palette readback from framebuffer (slow, clashes with texture in RT TC function, clashes with Target readback logic) - Developed new method SwSpriteRender with CPU rendering logic - Add OI_JakGames method using SwSpriteRender for CPU palette rendering (fast, does not clash with texture in RT TC function, no readback required) Bonus: fps also sees an improvement in Jak games 3-5 increase.
JibbityJobbity
pushed a commit
to JibbityJobbity/pcsx2
that referenced
this pull request
Jul 14, 2019
…X2#3001) Developed a new SW sprite render function, which is used to fix Jak and Daxter colors in Jak games and to remove the old Jak games hack which yielded wrong colors and clashed with TC search texture in RT function. - Remove OO_JakGames hack for palette readback from framebuffer (slow, clashes with texture in RT TC function, clashes with Target readback logic) - Developed new method SwSpriteRender with CPU rendering logic - Add OI_JakGames method using SwSpriteRender for CPU palette rendering (fast, does not clash with texture in RT TC function, no readback required) Bonus: fps also sees an improvement in Jak games 3-5 increase.
JibbityJobbity
pushed a commit
to JibbityJobbity/pcsx2
that referenced
this pull request
Jul 14, 2019
…X2#3001) Developed a new SW sprite render function, which is used to fix Jak and Daxter colors in Jak games and to remove the old Jak games hack which yielded wrong colors and clashed with TC search texture in RT function. - Remove OO_JakGames hack for palette readback from framebuffer (slow, clashes with texture in RT TC function, clashes with Target readback logic) - Developed new method SwSpriteRender with CPU rendering logic - Add OI_JakGames method using SwSpriteRender for CPU palette rendering (fast, does not clash with texture in RT TC function, no readback required) Bonus: fps also sees an improvement in Jak games 3-5 increase.
arcum42
pushed a commit
to arcum42/pcsx2
that referenced
this pull request
Jul 20, 2019
…X2#3001) Developed a new SW sprite render function, which is used to fix Jak and Daxter colors in Jak games and to remove the old Jak games hack which yielded wrong colors and clashed with TC search texture in RT function. - Remove OO_JakGames hack for palette readback from framebuffer (slow, clashes with texture in RT TC function, clashes with Target readback logic) - Developed new method SwSpriteRender with CPU rendering logic - Add OI_JakGames method using SwSpriteRender for CPU palette rendering (fast, does not clash with texture in RT TC function, no readback required) Bonus: fps also sees an improvement in Jak games 3-5 increase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developed a new SW sprite render function, which is used to fix Jak and Daxter colors in Jak games and to remove the old Jak games hack which yielded wrong colors and clashed with TC search texture in RT function.
clashes with texture in RT TC function, clashes with Target readback logic)
texture in RT TC function, no readback required)
Performances (SSE2, OGL HW, Intel UHD 620, i7-8550U, Win10x64):
Screenshots - Jak 3:
Master
Master with texture inside RT TC flag
Branch
Branch with texture inside RT TC flag