Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSdx-hw: New SW sprite render function, used in Jak games #3001

Merged
merged 1 commit into from Jul 12, 2019

Conversation

iMineLink
Copy link
Contributor

@iMineLink iMineLink commented Jun 29, 2019

Developed a new SW sprite render function, which is used to fix Jak and Daxter colors in Jak games and to remove the old Jak games hack which yielded wrong colors and clashed with TC search texture in RT function.

  • Remove OO_JakGames hack for palette readback from framebuffer (slow,
    clashes with texture in RT TC function, clashes with Target readback logic)
  • Developed new method SwSpriteRender with CPU rendering logic
  • Add OI_JakGames method using SwSpriteRender for CPU palette rendering (fast, does not clash with
    texture in RT TC function, no readback required)

Performances (SSE2, OGL HW, Intel UHD 620, i7-8550U, Win10x64):

Jak 3 Before After Change
Ingame 22 fps 25 fps +3 fps
Cutscene 19 fps 24 fps +5 fps

Screenshots - Jak 3:

Master
current-master-jak

Master with texture inside RT TC flag
current-master-jak-tex-in-rt

Branch
branch-jak

Branch with texture inside RT TC flag
branch-jak-tex-in-rt

@lightningterror lightningterror added this to the Release 1.6 milestone Jun 29, 2019
iMineLink referenced this pull request in iMineLink/pcsx2 Jul 6, 2019
Fixes Jak and Daxter colors in Jak games (old hack yielded wrong colors and
clashed with texture in RT TC hack)

- Remove OO_JakGames hack for palette readback from framebuffer (slow,
clashes with texture in RT TC hack, clashes with Target readback logic)
- Add OI_JakGames hack for CPU palette rendering (fast, does not clash with
texture in RT TC hack, no readback required)
- Extracted CPU rendering logic into dedicated method SwSpriteRender
@iMineLink iMineLink force-pushed the gsdx-oi-hack-jak-games branch 4 times, most recently from ae90f3d to eba540d Compare July 11, 2019 17:52
@iMineLink iMineLink changed the title GSRendererHW: Jak games OI hack CPU palette render GSRendererHW: New SW sprite render function, used in Jak games Jul 11, 2019
Developed a new SW sprite render function, which is used to fix
Jak and Daxter colors in Jak games and to remove the old Jak games hack
which yielded wrong colors and clashed with TC search texture in RT function.

- Remove OO_JakGames hack for palette readback from framebuffer (slow,
clashes with texture in RT TC function, clashes with Target readback logic)
- Developed new method SwSpriteRender with CPU rendering logic
- Add OI_JakGames method using SwSpriteRender for CPU palette rendering (fast,
does not clash with texture in RT TC function, no readback required)
@lightningterror lightningterror changed the title GSRendererHW: New SW sprite render function, used in Jak games GSdx-hw: New SW sprite render function, used in Jak games Jul 12, 2019
@lightningterror lightningterror merged commit f409079 into PCSX2:master Jul 12, 2019
JibbityJobbity pushed a commit to JibbityJobbity/pcsx2 that referenced this pull request Jul 14, 2019
…X2#3001)

Developed a new SW sprite render function, which is used to fix
Jak and Daxter colors in Jak games and to remove the old Jak games hack
which yielded wrong colors and clashed with TC search texture in RT function.

- Remove OO_JakGames hack for palette readback from framebuffer (slow,
clashes with texture in RT TC function, clashes with Target readback logic)
- Developed new method SwSpriteRender with CPU rendering logic
- Add OI_JakGames method using SwSpriteRender for CPU palette rendering (fast,
does not clash with texture in RT TC function, no readback required)

Bonus: fps also sees an improvement in Jak games 3-5 increase.
JibbityJobbity pushed a commit to JibbityJobbity/pcsx2 that referenced this pull request Jul 14, 2019
…X2#3001)

Developed a new SW sprite render function, which is used to fix
Jak and Daxter colors in Jak games and to remove the old Jak games hack
which yielded wrong colors and clashed with TC search texture in RT function.

- Remove OO_JakGames hack for palette readback from framebuffer (slow,
clashes with texture in RT TC function, clashes with Target readback logic)
- Developed new method SwSpriteRender with CPU rendering logic
- Add OI_JakGames method using SwSpriteRender for CPU palette rendering (fast,
does not clash with texture in RT TC function, no readback required)

Bonus: fps also sees an improvement in Jak games 3-5 increase.
JibbityJobbity pushed a commit to JibbityJobbity/pcsx2 that referenced this pull request Jul 14, 2019
…X2#3001)

Developed a new SW sprite render function, which is used to fix
Jak and Daxter colors in Jak games and to remove the old Jak games hack
which yielded wrong colors and clashed with TC search texture in RT function.

- Remove OO_JakGames hack for palette readback from framebuffer (slow,
clashes with texture in RT TC function, clashes with Target readback logic)
- Developed new method SwSpriteRender with CPU rendering logic
- Add OI_JakGames method using SwSpriteRender for CPU palette rendering (fast,
does not clash with texture in RT TC function, no readback required)

Bonus: fps also sees an improvement in Jak games 3-5 increase.
arcum42 pushed a commit to arcum42/pcsx2 that referenced this pull request Jul 20, 2019
…X2#3001)

Developed a new SW sprite render function, which is used to fix
Jak and Daxter colors in Jak games and to remove the old Jak games hack
which yielded wrong colors and clashed with TC search texture in RT function.

- Remove OO_JakGames hack for palette readback from framebuffer (slow,
clashes with texture in RT TC function, clashes with Target readback logic)
- Developed new method SwSpriteRender with CPU rendering logic
- Add OI_JakGames method using SwSpriteRender for CPU palette rendering (fast,
does not clash with texture in RT TC function, no readback required)

Bonus: fps also sees an improvement in Jak games 3-5 increase.
@iMineLink iMineLink deleted the gsdx-oi-hack-jak-games branch January 28, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants