Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Fix build with cmake-3.5.2. #3117

Merged
merged 1 commit into from Sep 22, 2019
Merged

cmake: Fix build with cmake-3.5.2. #3117

merged 1 commit into from Sep 22, 2019

Conversation

orbea
Copy link
Contributor

@orbea orbea commented Sep 21, 2019

For Slackware stable (14.2) it has the older cmake-3.5.2 which does not seem to support GREATER_EQUAL. So I replaced it with VERSION_EQUAL and VERSION_GREATER which is more verbose, but works with both newer and older cmake versions.

Unfortunately I am stuck testing against older cmake versions until Slackware 15.0 is out (When its ready).

CMake Error at cmake/SearchForStuff.cmake:225 (if):
  if given arguments:

    "GCC_VERSION" "GREATER_EQUAL" "9.0" "AND" "GCC_VERSION" "LESS" "9.2"

  Unknown arguments specified
Call Stack (most recent call first):
  CMakeLists.txt:27 (include)


-- Configuring incomplete, errors occurred!
See also "/tmp/SBo/pcsx2/build/CMakeFiles/CMakeOutput.log".
See also "/tmp/SBo/pcsx2/build/CMakeFiles/CMakeError.log".

@orbea

This comment has been minimized.

@arcum42
Copy link
Contributor

arcum42 commented Sep 22, 2019

Works fine on my side with a newer version of cmake, tested both with gcc 9.1.0 and clang. I could go either way on which version of the check to use, but I'm fine with the current one, so I'll merge that.

@arcum42 arcum42 merged commit d92e434 into PCSX2:master Sep 22, 2019
@orbea orbea deleted the cmake branch September 22, 2019 02:59
KrossX pushed a commit to KrossX/pcsx2 that referenced this pull request Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants