Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] PCSX2 1.6 Documentation Overhaul #3139

Merged
merged 46 commits into from Feb 10, 2020

Conversation

RedPanda4552
Copy link
Sponsor Contributor

Documentation overhaul for 1.6 release 🔜

Starting with a rewrite of the old FAQ PDF, now in Markdown. Modernized, dropped some irrelevant bits, added some new ones.

WIP, ideally should have all docs ready in this PR before merge. Starting with this and putting PR up for visibility.

@pgert
Copy link
Contributor

pgert commented Oct 27, 2019

I'm saddened that you haven't included my BIOS & memcard tools guide.
https://forums.pcsx2.net/Thread-An-orientation-through-some-of-the-PCSX2-BIOS-memcard-tools-Windows?pid=183709#pid183709

README.md Outdated Show resolved Hide resolved
@ssakash
Copy link
Member

ssakash commented Nov 2, 2019

PassMark Single Thread Performance rating near or greater than 1600

This value feels too high for minimum requirements.

@lightningterror
Copy link
Contributor

This value feels too high for minimum requirements.

Feels right to me, we've been recommending 1600 for several years now.

pcsx2/Docs/PCSX2_FAQ.md Outdated Show resolved Hide resolved
pcsx2/Docs/PCSX2_FAQ.md Outdated Show resolved Hide resolved
* Want to make changes to emulator code? [Check out the issue tracker](https://github.com/PCSX2/pcsx2/issues), or [fork the PCSX2 repository and work on your own ideas](https://github.com/PCSX2/pcsx2).
* Want to patch games? [Check out the cheats and patches forum thread for inspiration](https://forums.pcsx2.net/Thread-Post-your-PCSX2-cheats-patches-here). There are other threads to find as well, [such as those dedicated to 60 FPS patches](https://forums.pcsx2.net/Thread-60-fps-codes) or [widescreen patches](https://forums.pcsx2.net/Thread-PCSX2-Widescreen-Game-Patches).
* Want to report bugs you have discovered in your games? [Head over to the Bug Reporting section of the PCSX2 forums](https://forums.pcsx2.net/Forum-Bug-reporting).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a section on how to report an issue (link to how to make gs dump etc) or link to our issue guidelines

| Operating System | CPU | GPU | RAM |
| --- | --- | --- | --- |
| - Windows 7 or newer (32 or 64 bit) <br/> - Ubuntu 18.04/Debian or newer, Arch Linux, or other distro (32 or 64 bit) | - Supports SSE2 <br/> - [PassMark Single Thread Performance](https://www.cpubenchmark.net/singleThread.html) rating near or greater than 1600 <br/> - Two physical cores, with hyperthreading | - Direct3D11 support <br/> - OpenGL 3.x support <br/> - [PassMark G3D Mark](https://www.videocardbenchmark.net/high_end_gpus.html) rating around 3000 (GeForce GTX 750) <br/> - 2 GB Video Memory | 4 GB |

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe installation instructions for common OS

  • arch
  • debian/ubuntu
  • windows
  • fedora (think there is a community package for it in copr or something)

I know for example ubuntu might be kind of annoying because of multilib

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioning each linux distro in the readme may be a bit too "heavy".
Maybe there could be a link over "linux" which points to a wiki page detailing every one.

@tadanokojin
Copy link
Member

@lightningterror @ssakash then a wise man said "we shall add more threads"

README.md Outdated Show resolved Hide resolved
@MrCK1 MrCK1 added this to the Release 1.6 milestone Nov 15, 2019
pcsx2/Docs/PCSX2_FAQ.md Outdated Show resolved Hide resolved
@mirh
Copy link

mirh commented Nov 24, 2019

Feels right to me, we've been recommending 1600 for several years now.

And? Requirements should depend on how well games run, not whether most people can afford to buy such hardware or not.
And I, for one, can play plenty of games (actually every one I ever tried) with barely more than 1000

Maybe it's just me to be lucky, but the I'd like some more discussion on how game heaviness distribution goes.

EDIT: the cores note is very perfect now btw, gg

@ssakash
Copy link
Member

ssakash commented Nov 26, 2019

I agree with @mirh, minimum requirement should be the utmost minimum single thread performance you need to emulate the system, some games need really high value, but that doesn't make that 4th gen i3 with 1.4K STP not fit for PCSX2.

I'm not even sure how you come up with the 1600 value either, there are tons of games which are less demanding on the CPU that even lower values like the one mirh mentioned would be enough. I don't want anyone to come to the wrong conclusion thinking their PC is not fit for PCSX2 just by this high minimum requirement you have for it.

@mirh
Copy link

mirh commented Nov 26, 2019

It will be a good deal of arguing though, whether "the absolute minimum", or "some decent number of games works" (and even then, whether you should just take "raw frequency", or discount titles for popularity) is gomna be the better metrics.

Also, most of these considerations are also true for recommended requirements I guess. I don't think that we should have "play SOTC at full speed" as it.

@tadanokojin
Copy link
Member

And I, for one, can play plenty of games (actually every one I ever tried) with barely more than 1000

here are tons of games which are less demanding on the CPU that even lower values like the one mirh mentioned would be enough

Then name some.

@turtleli
Copy link
Member

turtleli commented Feb 9, 2020

I think you need to modify the main CMakeLists.txt.

@lightningterror
Copy link
Contributor

lightningterror commented Feb 9, 2020

For cmake btw here, need to add the config guide

INSTALL(FILES "${CMAKE_SOURCE_DIR}/bin/docs/PCSX2_FAQ.pdf" DESTINATION "${DOC_DIR}")

Copy link
Contributor

@lightningterror lightningterror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we are good, maybe we can squash the newest commit in first.

Copy link
Contributor

@lightningterror lightningterror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images for the config guide look low res, can you use better quality ones, also use images from the pr but rebased with latest dev build since DPI scaling was fixed in the first time wizard as well as to match the config and faq doc strings.

@RedDevilus
Copy link
Contributor

Nitpicky: The header of the Configuration_Guide ( PDF ) says Configuration_Guide.md + There is an empty page number 6.

Header for PCSX2_FAQ (PDF) says PCSX2_FAQ.md too.

@lightningterror
Copy link
Contributor

It's how the conversion is done so it's fine.

@RedDevilus
Copy link
Contributor

I have changed it myself if u still want the changes i proposed. But i don't want to pollute with making another PR.

7da0ff6
Also in my branch: docs2
I'm sorry if i'm being too excessive in doing this.

Copy link
Contributor

@lightningterror lightningterror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's get it finally merged.

@lightningterror lightningterror merged commit a7285ff into PCSX2:master Feb 10, 2020
KrossX pushed a commit to KrossX/pcsx2 that referenced this pull request Feb 19, 2020
Update all documentation for 1.6.
Source files for documentation are in md format and are kept in pcsx2\pcsx2\Docs, final exported/converted docs are in pdf format (Configuration_Guide and PCSX2_FAQ).

Update First time wizard to reflect recent documentation changes.
Update cmake to reflect recent documentation changes.

PO/POT/MO Localisation needs to be updated for the First time wizard to include the documentation changes.
NSIS installer needs to be updated to reflect the recent changes.
@RedPanda4552 RedPanda4552 deleted the docs branch January 3, 2021 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet