Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcsx2: purge fmv in sw hack #3806

Merged
merged 2 commits into from Oct 9, 2020
Merged

Conversation

tadanokojin
Copy link
Member

@tadanokojin tadanokojin commented Oct 7, 2020

Rationale:
The hack was recently broken on master. We could fix it, but it's sort of pointless. Additionally, #3549 will break it as it forces the window to close when the renderer switches. This is desired as sharing a surface between different renderers is bad behavior.

At it's best, it offered a users a way to work around that some FMVs are not properly displayed by the HW renderer due to limitations of the cache by automatically switching to the more compatible sw renderer when they played.

At it's worst, it's a threading nightmare that barely worked and was never going to be a long term solution especially seeing as it conflicts with future changes that we would like to make.

Instead, I'll purge it and we'll work on making the HW renderer better instead of relying on a hack. Games which require sw mode will be tracked here: #3805

close: #3804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gamefixes: "Switch to GSdx software rendering when an FMV plays" is hard crashing the emulator
2 participants