Common: Fix GetWorkingDirectory on unix#5164
Merged
Merged
Conversation
|
I can confirm this fixes the issue. |
stenzek
reviewed
Dec 15, 2021
Mrlinkwii
approved these changes
Dec 15, 2021
TellowKrinkle
force-pushed
the
FixGetCWD
branch
from
523d9a9 to
fda38bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes an issue where
GetWorkingDirectorywould return astd::stringcontaining null characters at the endFixes #5163
Rationale behind Changes
When you concatenated those strings with other strings, the null characters would make most C utilities not notice the concatenation
Suggested Testing Steps
Attempt to make a block dump in Linux