GIF: Separate GIF Reset and GIF DMA Reset #5324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two shouldn't be reset together anyway, the GIF has no control over the DMA.
|
Confirmed, does indeed fix air ranger 2. |
JordanTheToaster
approved these changes
Jan 12, 2022
lightningterror
approved these changes
Jan 12, 2022
Mrlinkwii
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Removes DMA reset stuff from a GIF reset.
Rationale behind Changes
The two shouldn't be reset together anyway, the GIF has no control over the DMA, it was incorrect and causing currently running DMA's to get stuck in an infinite loop.
Suggested Testing Steps
Run games, make sure they still work, no specific games here (Except Air Ranger 2) was known to be affected directly, but the adverse is unknown.
Fixes Air Ranger 2 - Rescue Helicopter infinite loop on boot.