Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: copy resources in build folder. #5457

Merged

Conversation

iMineLink
Copy link
Contributor

Description of Changes

copy resources from bin to pcsx2 target build folder when building with cmake.

Rationale behind Changes

make it easier to run the pcsx2 target via vscode cmake integration on windows.

Suggested Testing Steps

check that building and running an all platforms is not broken.
on windows, check that you can run the pcsx2 target via vscode cmake integration and it finds the resources folder.

@TellowKrinkle
Copy link
Member

add_custom_command lets you specify multiple commands to run in series
If you do the two commands separately, on multicore builds, they could run out of order AFAIK

@iMineLink iMineLink force-pushed the cmake/copy-resources-in-build-folder branch from 5c863a4 to bfbe289 Compare February 3, 2022 23:16
@iMineLink
Copy link
Contributor Author

thanks for the tip, now a single add_custom_command call specifies both directories creation and file copy commands.

@refractionpcsx2 refractionpcsx2 merged commit 061fff6 into PCSX2:master Feb 6, 2022
@iMineLink iMineLink deleted the cmake/copy-resources-in-build-folder branch May 29, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants