GSdx: better framebuffer format #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Either 32bits/24bits/16bits
It would allow to easy tune the parameter to support 24 bits format
Please test it! GS supports 3 formats for the output: 32 bits: normal case => no change 24 bits: like 32 bits but without alpha channel => mask alpha channel (ie don't write it anymore) => Always uses 1.0f as blending coefficient 16 bits: RGB5A1, emulated by a 32 bits openGL texture. I think it will be more correct to use a real 16 bits GL texture. Unfortunately it would cost several (slow) target conversions. Anyway as a current solution => apply a mask of 0xF8 on color when SW blending is used (improve Castlevania shadow) unfortunately normal blending mode still uses the full range of colors! This commit also corrects a couple of blending factor. 128/255 is equivalent to 1.0f in PS2, whereas GPU uses 1.0f. So the blending factor must be 255/128 instead of 2 Note: disable CRC hack and enable accurate_colclip to see Castlevania shadow ^^ (issue #380). Note2: SW renderer is darker on Castlevania. I don't know why maybe linked to the 16 bits format poorly emulated
|
It fixes band of guitar heroes 3 |
gregory38
added a commit
that referenced
this pull request
Jun 1, 2015
GSdx: better framebuffer format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It requires a lots of tests ! I'm really afraid of regression.
It improves Castlevania rendering (accurate_colclip = 1 & CRC disabled)