Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common: Avoid assert in libstdc++ #5891

Merged
merged 1 commit into from
Apr 17, 2022
Merged

Common: Avoid assert in libstdc++ #5891

merged 1 commit into from
Apr 17, 2022

Conversation

TellowKrinkle
Copy link
Member

@TellowKrinkle TellowKrinkle commented Apr 16, 2022 •
edited

Description of Changes

Work around a libstdc++ assert that should be disabled in C++17

Rationale behind Changes

Not assertion failing is good

Suggested Testing Steps

  • Make sure no stdlibs assert
  • Test PCSX2 on an ISA with weak memory ordering and... okay maybe this won't be tested

@TellowKrinkle TellowKrinkle changed the title Common: Fix wrong memory order in WorkSema Common: Avoid assert in libstdc++ Apr 16, 2022
@refractionpcsx2 refractionpcsx2 merged commit eb60e9a into PCSX2:master Apr 17, 2022
@TellowKrinkle TellowKrinkle deleted the SemaFix branch April 17, 2022 20:01
@SamRH SamRH mentioned this pull request Apr 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TellowKrinkle @refractionpcsx2