Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPU: Reorder DMA timing for IPU_TO and IPU_FROM #6313

Merged
merged 4 commits into from Jun 4, 2022

Conversation

refractionpcsx2
Copy link
Member

@refractionpcsx2 refractionpcsx2 commented Jun 2, 2022

Description of Changes

Reorders how the delays for IPU DMA's happen and how quickly the IPU command continues.
Bumps savestate version. Sorry not sorry.

Rationale behind Changes

These timings were a mess and IPU was being triggered way too early, causing timing errors in games such as Tales of Rebirth

Suggested Testing Steps

Make sure no videos are busted, else I may cry.

Fixes regression on Tales of Rebirth from #6270
Fixes #6290 Guilty Gear XX regression

@Goatman13
Copy link
Contributor

Thanks for fixing that. I had no idea that can be DMA issue after all.
I tested few games like T4, TTT, Onimusha, Tiger Woods, Guilty Gear (fixed with that pr) etc. All of them work as expected. Nice work.

@refractionpcsx2
Copy link
Member Author

Thanks for fixing that. I had no idea that can be DMA issue after all. I tested few games like T4, TTT, Onimusha, Tiger Woods, Guilty Gear (fixed with that pr) etc. All of them work as expected. Nice work.

I think it was one of those things, where you fix one thing and it brings up another issue, but the problem was it wasn't timing IPU_TO properly, so it was transferring the data to the IPU, then immediately processing it, instead of simulating the transfer time, so it was all getting out of whack and messing it up. I don't know why it wasn't an issue before, but I'm glad it wasn't too hard to fix.

I am a little nervous of regressions, so I am asking people to test their games and make sure everything else is okay (I had issues with Digital Devil Saga and Mana Khemia)

@refractionpcsx2 refractionpcsx2 mentioned this pull request Jun 3, 2022
25 tasks
@darkxex
Copy link
Contributor

darkxex commented Jun 3, 2022

PCSX2-windows-Qt-x64-AVX2-sha[a05db3b]
still broken mana khemia... in this pull.

Pcsx2.Tested.2022.06.03.-.19.34.37.01.mp4

downloaded build of here.
https://github.com/PCSX2/pcsx2/actions/runs/2432272169

@refractionpcsx2
Copy link
Member Author

That's a different issue related to GIF timing.

@darkxex
Copy link
Contributor

darkxex commented Jun 3, 2022

That's a different issue related to GIF timing.

oh sorry my friend i just read that and i was wrong.
image

@refractionpcsx2
Copy link
Member Author

Yeah that's a different thing, which causes the video/screens come up when you boot the game, it would actually hang without that

Modify IPU to run on internal interrupts to give some timing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Regression - Guilty Gear XX ACPR - Freeze at the logo
3 participants