New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finally remove wxWidgets #7610
Finally remove wxWidgets #7610
Conversation
d680729
to
c47849b
Compare
c47849b
to
f754335
Compare
Qt didn't break (I was able to launch and play a few games fine) I had to re-add package mode though to make an Arch package 🐸 |
You make Linux users (including me) look horrible. We are an open community, you are able to suggest ideas to us. Instead of passive aggressive remarks, why not make a contribution. Edit: Looks like the original comment was edited, my response was a response to that. |
Well I've deleted the comment because it's a waste of time. I already asked for a sane Qt5 support for Linux users, like all other major emulators offer as Citra, Yuzu, RPCS3, Dolphin do or just keep wxWidgets - Cemu works just fine. |
Continuing to be passive aggressive isn't helping convince anyone. |
WX has long survived its initial projections of survival, and if you dislike it just stick to the older builds. Just like older OS with outdated specs fit with outdated software. Keeping compatibility for everything alive would require postponing progress or adding hacks back in again. If you want to handle that aspect for us, go ahead. But don't expect us to do it for you, unless you have some valid reasons for atleast 10% of PCSX2 users. Either way we are all volunteers so we don't have to do anything that users suggest, but doesn't mean we don't listen and think about how much ideas help PCSX2. Trying to maintain WX was a nightmare when I tried to improve upon the monstrosity, now I don't have to cringe looking at the Qt variant having cleaned up the old mess. WX also has higher input latencies when I compared it to Qt so yeah, it's not done out of spite against users and perhaps you are just used to it but this isn't Bethesda or other emulators. I apologise if this isn't the response you wanted but you did make a previous GitHub issue that was rejected. And the other emulators started at Qt 5 or below and needs to revise a ton of the old code to be compliant for 6. PCSX2 started afresh with Qt 6.X so it made sense at the time to not hack it in for Qt5. |
endif() | ||
if(NOT WIN32 AND NOT DISABLE_PCSX2_WRAPPER) | ||
# special case to avoid having linux files in windows | ||
INSTALL(FILES "${CMAKE_SOURCE_DIR}/linux_various/PCSX2-linux.sh" DESTINATION "${CMAKE_SOURCE_DIR}/bin") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line tells it to install PCSX2-linux.sh, but this PR also deletes that file.
Since Qt6 is meant for Windows 10 it's used. That's it. If I point out at least to keep it for legacy purposes: won't do. The project literally merged commits hours ago for the WX build but well: won't do. As I said it's a waste of time. |
This sounds more like a disorganized rant about Windows being the end of the world than anything about dependency management. Linux users have the AppImage to take care of all that for them. Packagers can use a Qt 6 package when it is made available to them by their distro's package maintainers. End of story. Locked. |
Also FYI, dolphin has moved to qt 6 and made win 10 1908 the minimum requirement. If you're comparing their previous release, ours also works down to Windows 7 Please don't come in here with your disingenuous arguments |
This is ridiculous that we have to lock PRs because some users get mad about our choices. Clearly you haven't worked with the PCSX2 code base - the wx frontend is riddled with bugs, race conditions, overengineering and is very difficult to work with. That's why I tossed it out and started fresh. If you want to use wx, the code is there. You can fork and maintain it yourself. That's the beauty of open source. But don't expect the maintainers to do it for you, when it's actively preventing us from making improvements (e.g. I can't do combined audio+video dumping until wx is gone). Plus, it hasn't been at feature parity in some time. |
f754335
to
854d49f
Compare
Note: I've included #6161 in here for now, so we don't need to resolve the conflicts later. After the debugger is merged, this is good to go. |
854d49f
to
3d6e94e
Compare
Description of Changes
A year later and a ton of work, wx is finally gone! Celebrations!
Obviously merging this has to wait until the debugger is also merged (and maybe guitars).
CI probably needs to have some GCC builds added for coverage.
Rationale behind Changes
Where do I begin....
Suggested Testing Steps
Make sure Qt didn't break.