Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve nVidia Optimus and AMD PowerXpress compatibility #767

Merged
merged 1 commit into from Aug 24, 2015

Conversation

Projects
None yet
8 participants
@charliebruce
Copy link
Contributor

commented Aug 15, 2015

Fix for #659 - signal to the nVidia drivers that, if it is an "Optimus"-enabled computer, that the high-performance graphics card should be used with PCSX2. This export must be added to the main executable not to the graphics plugin(s) - the nVidia drivers only look at the main executable.

Sorry this simple change is spread over multiple commits!

@charliebruce charliebruce changed the title Improve nVidia Optimus compatbility Improve nVidia Optimus and AMD PowerXpress compatibility Aug 15, 2015

@gregory38

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2015

Could you rebase and squash all commits into a single one ?

@charliebruce charliebruce force-pushed the charliebruce:master branch 2 times, most recently to 7753297 Aug 16, 2015

@charliebruce

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2015

Just reorganised it all into one commit.

@mirh

This comment has been minimized.

Copy link

commented Aug 16, 2015

Just for the records, AMD is using Enduro designation at the moment.

@gregory38

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2015

@bositman could you check compilation on vs2013.

@gregory38 gregory38 added the Reviewed label Aug 17, 2015

@gregory38

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2015

!!! Don't merge it now. We need to do #690 first !!!

@micove

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2015

Well since I'm updating the Debian copyright file right now to upload the current master. I only want to point out that the copyright header for the new cpp file is missing.

@bositman

This comment has been minimized.

Copy link
Member

commented Aug 17, 2015

Yeah it compiles OK in VS 2013

@refractionpcsx2

This comment has been minimized.

Copy link
Member

commented Aug 18, 2015

#690 is merged, this now has conflicts to fix up

@bositman bositman removed their assignment Aug 20, 2015

@micove

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2015

@charliebruce

Hey, could you rebase and squash all commits into a single one?

I don't have Optimus or the AMD equivalent to check if this actually works. I just know it compiles.

@charliebruce charliebruce force-pushed the charliebruce:master branch Aug 24, 2015

@charliebruce

This comment has been minimized.

Copy link
Contributor Author

commented Aug 24, 2015

Just rebased and merged, should all be fine now? Tested on my laptop with Optimus and it works correctly. I don't have an AMD Hybrid Graphics chipset to test it with.

@micove

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2015

If it works for optimus then it's fine then.

I would have used _WIN32 which is a builtin instead of _WINDOWS which is a relic from the 16-bit era. Also I would have put the file somewhere else (not sure where maybe one directory down) other than the VSprojects folder. To be fair _WINDOWS is used in other files and IopSif.cpp is also in that same folder so I'm probably being picky.

@charliebruce

This comment has been minimized.

Copy link
Contributor Author

commented Aug 24, 2015

I'll make those changes quickly if you like - shouldn't take me long.

On 24 August 2015 at 12:30, micove notifications@github.com wrote:

If it works for optimus then it's fine then.

I would have used _WIN32 which is a builtin instead of _WINDOWS which is a
relic from the 16-bit era. Also I would have put the file somewhere else
(not sure where maybe one directory down) other than the VSprojects folder.
To be fair _WINDOWS is used in other files and IopSif.cpp is also in that
same folder so I'm probably being picky.


Reply to this email directly or view it on GitHub
#767 (comment).

@micove

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2015

Oh sure, I would merge it afterwards.

Request the use of the high-performance graphics card on systems where
multiple graphics processors are available (nVidia Optimus, AMD Hybrid
Graphics).

@charliebruce charliebruce force-pushed the charliebruce:master branch to 37cfdf6 Aug 24, 2015

@charliebruce

This comment has been minimized.

Copy link
Contributor Author

commented Aug 24, 2015

Should all be done now.

@micove

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2015

I already checked the code and I just compiled it and ran it. It did not break my laptop which has no optimus or amd equivalent therefore I'm merging it.

Thanks!

micove added a commit that referenced this pull request Aug 24, 2015

Merge pull request #767 from charliebruce/master
Improve nVidia Optimus and AMD PowerXpress compatibility

@micove micove merged commit 94d8d32 into PCSX2:master Aug 24, 2015

@avih

This comment has been minimized.

Copy link
Member

commented Aug 24, 2015

Nice. Just tested this patch with AMD 8850m in "Enduro" configuration, with Catalyst 15.7, and it seems to work well!

(had to first "restore defaults" for the pcsx2 executable at Catalyst -> power -> switchable graphics application settings, and then, without this patch it would use the Intel iGPU by default, and after the patch it uses the AMD GPU automatically).

Thanks!

@karasuhebi

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2015

Thanks for this!

@mirh mirh referenced this pull request Dec 27, 2015

Merged

Nvidia Optimus support #493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.