New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve nVidia Optimus and AMD PowerXpress compatibility #767
Conversation
Could you rebase and squash all commits into a single one ? |
d775ae2
to
7753297
Compare
Just reorganised it all into one commit. |
Just for the records, AMD is using Enduro designation at the moment. |
@bositman could you check compilation on vs2013. |
!!! Don't merge it now. We need to do #690 first !!! |
Well since I'm updating the Debian copyright file right now to upload the current master. I only want to point out that the copyright header for the new cpp file is missing. |
Yeah it compiles OK in VS 2013 |
#690 is merged, this now has conflicts to fix up |
Hey, could you rebase and squash all commits into a single one? I don't have Optimus or the AMD equivalent to check if this actually works. I just know it compiles. |
Just rebased and merged, should all be fine now? Tested on my laptop with Optimus and it works correctly. I don't have an AMD Hybrid Graphics chipset to test it with. |
If it works for optimus then it's fine then. I would have used _WIN32 which is a builtin instead of _WINDOWS which is a relic from the 16-bit era. Also I would have put the file somewhere else (not sure where maybe one directory down) other than the VSprojects folder. To be fair _WINDOWS is used in other files and IopSif.cpp is also in that same folder so I'm probably being picky. |
I'll make those changes quickly if you like - shouldn't take me long. On 24 August 2015 at 12:30, micove notifications@github.com wrote:
|
Oh sure, I would merge it afterwards. |
multiple graphics processors are available (nVidia Optimus, AMD Hybrid Graphics).
Should all be done now. |
I already checked the code and I just compiled it and ran it. It did not break my laptop which has no optimus or amd equivalent therefore I'm merging it. Thanks! |
Improve nVidia Optimus and AMD PowerXpress compatibility
Nice. Just tested this patch with AMD 8850m in "Enduro" configuration, with Catalyst 15.7, and it seems to work well! (had to first "restore defaults" for the pcsx2 executable at Catalyst -> power -> switchable graphics application settings, and then, without this patch it would use the Intel iGPU by default, and after the patch it uses the AMD GPU automatically). Thanks! |
Thanks for this! |
Fix for #659 - signal to the nVidia drivers that, if it is an "Optimus"-enabled computer, that the high-performance graphics card should be used with PCSX2. This export must be added to the main executable not to the graphics plugin(s) - the nVidia drivers only look at the main executable.
Sorry this simple change is spread over multiple commits!