Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS/HW: Adjust Barnyard fix for Jurassic Park and Nicktoons Unite #7848

Merged
merged 1 commit into from Jan 11, 2023

Conversation

stenzek
Copy link
Member

@stenzek stenzek commented Jan 9, 2023

Description of Changes

Draws its mipmaps at runtime in a very similar way, except with 24-bit textures as well as 16/32-bit.

Rationale behind Changes

Closes #6953.
Closes #5743.

Suggested Testing Steps

Test Jurassic Park and Nicktoons. I don't have the games, only the GS dumps, so someone who owns them will have to check.

Copy link
Contributor

@lightningterror lightningterror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename GSC_Barnyard to something else since multiple games use it?

@RedDevilus
Copy link
Contributor

Maybe rename GSC_Barnyard to something else since multiple games use it?

GSC_RecursiveMipmappingShit or something similar I guess.

@stenzek
Copy link
Member Author

stenzek commented Jan 9, 2023

It's noted in the source which games use it

If you know the name of the engine, feel free to rename it, but otherwise it's way too specific to have a general name imo.

@refractionpcsx2
Copy link
Member

refractionpcsx2 commented Jan 9, 2023

TOSHI game engine :)

This should give you an idea of the games this will affect https://en.wikipedia.org/wiki/Blue_Tongue_Entertainment

@RedDevilus
Copy link
Contributor

I guess the other games, probably also need to be checked then:
image

Draws its mipmaps at runtime in a very similar way, except with 24-bit
textures as well as 16/32-bit.
@refractionpcsx2
Copy link
Member

refractionpcsx2 commented Jan 10, 2023

Battle for Volcano Island needs it
image

With CRC hack applied:
image

Everything else is A-OK without it :)

@lightningterror
Copy link
Contributor

Is this good to go for merge?

@refractionpcsx2
Copy link
Member

Would be cool to get Battle for Volcano Island added first, but not the end of the world if it isn't as it can be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants