Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameDB: Various Armored Core Improvements #8291

Merged
merged 1 commit into from Feb 28, 2023
Merged

GameDB: Various Armored Core Improvements #8291

merged 1 commit into from Feb 28, 2023

Conversation

forrvalhalla
Copy link
Contributor

@forrvalhalla forrvalhalla commented Feb 28, 2023

Improvements made for Armored Core 2 Another Age, Armored Core 3 Silent Line, and Armored Core Last Raven

Description of Changes

Made various changes in GameDB to a select few Armored Core games.

Removed Round Sprite from AC3SL and ACLR.
Added Half-Pixel Offset changes to AC2AA and ACLR.
Added Target Partial Invalidation to NTSC-U and PAL-E AC3SL.

Rationale behind Changes

Round Sprite breaks the in-game HUD elements for AC3SL and ACLR, while giving negligible to no improvements. Interestingly, Round Sprite does help AC3, which might be the reason it was added onto 3SL as well.
ezgif-1-f8f2d394d1

HPO fixes misaligned shadows and AC reflection textures in ACLR and AC2AA respectively, and fixes the double-image ghosting/blur in ACLR.

Note that this does add 2px of garbage pixels in the top and left side of ACLR's garage, but the image clarity boost is worth the sacrifice.
ezgif-1-e2af256132

Added Target Partial Invalidation to NTSC-U and PAL-E AC3SL, as all other regions of AC3 and AC3SL have this fix and it does seem to help out with texture corruption.

Suggested Testing Steps

Tested both NTSC-U and NTSC-J regions of all three games.

Someone else might have to ensure AC3SL doesn't blow up from the Target Partial Invalidation changes I made, but it seems to be working fine in my tests.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a contribution to PCSX2

As this is your first pull request, please be aware of the contributing guidelines.

Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.

Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!

@refractionpcsx2 refractionpcsx2 merged commit cb786f0 into PCSX2:master Feb 28, 2023
@refractionpcsx2
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants