GS: Compensate for misaligned partial 24bit local->host transfers #8445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refractionpcsx2
force-pushed
the
gs_offsetsplit
branch
from
51ed1c8
to
d22bb23
Compare
|
Tested Keroro Gunso against this PR, and it seems that its still somewhat broken :(
|
lightningterror
approved these changes
Mar 20, 2023
|
As I said in the OP "There is another issue with hardware mode", however that wasn't it... that looks like the second half of the transfer just didn't happen, wtf... |
|
I tested We Love Katamari and it is fixed. |
|
Thanks for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Compensates for misaligned transfers which generally happen with 24bit transfers when the transfer is split.
Rationale behind Changes
In Keroro Gunso and We Love Katamari it downloads the 24 bit framebuffer in 2 parts, but it ends the first transfer 1 channel in to the 3 channel pixel, meaning it's offset strangely when it does the second part of the transfer. So to compensate for this we do the whole pixel it ends on, then do an offset on the second part of the transfer, this stops the colours being incorrect as a bar across the bottom.
Suggested Testing Steps
Test Keroro Gunso - Mero Mero Battle Royale pause screen and We Love Katamari Damacy transition in to the collection.
Keroro Gunso: (There is another issue I need to solve with HW mode where the download fails first time, need to investigate)
Master:
PR:
We Love Katamari:
Master:
PR:
Fixes #8146
Fixes #8441