-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GS:OGL:Shaders: Formatting #8650
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is going to conflict with #8613, and in a nasty way (I removed the GS completely). |
I forgot that wasn't merged yet. |
TellowKrinkle
force-pushed
the
OGLShaderFormat
branch
from
April 14, 2023 05:46
55935f9
to
b63fe1a
Compare
JordanTheToaster
approved these changes
Apr 14, 2023
Mrlinkwii
approved these changes
Apr 14, 2023
TellowKrinkle
force-pushed
the
OGLShaderFormat
branch
from
April 17, 2023 01:54
16d86fc
to
7ff6706
Compare
JordanTheToaster
approved these changes
Apr 17, 2023
I'll go ahead and merge this, other formatting stuff can be done at a later time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Less aggressive version of #8648
Rationale behind Changes
Our GLSL shaders have a lot of nested ifdefs which are incredibly confusing with the default clang-format formatting
Suggested Testing Steps
Test OpenGL things