VIF: Improve IR setup for skipped unpack inputs/writes #8778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refractionpcsx2
force-pushed
the
vif_skipinput
branch
from
68232e0
to
c8c8754
Compare
seta-san
reviewed
May 3, 2023
| @@ -263,6 +258,26 @@ void VifUnpackSSE_Dynarec::ModUnpack(int upknum, bool PostOp) | |||
| } | |||
There was a problem hiding this comment.
on a line a couple up it says "pxFailRel(fmt::format("Vpu/Vif - Invalid Unpack! [%d]", upknum).c_str());" but it never gives the the value of upknum.
There was a problem hiding this comment.
when the error is triggered the value of it is gonna always be 11.
|
Is that new? That shouldn't have changed |
It is from 2020. https://forums.pcsx2.net/Thread-True-Crime-Streets-of-L-A-SLUS-20550-U--29732?pid=616280#pid616280 |
|
Then I don't care |
Mrlinkwii
approved these changes
May 3, 2023
refractionpcsx2
force-pushed
the
vif_skipinput
branch
2 times, most recently
from
983c611
to
3b07975
Compare
refractionpcsx2
force-pushed
the
vif_skipinput
branch
from
3b07975
to
976aeb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Improved detection of when rows/cols/write protect are used instead of input data, reducing codegen of the VIF JIT
Rationale behind Changes
potentially more brr in some places, but not much.
Suggested Testing Steps
Test games, if it says "Skipping stuff!" in the console, it's hit the new code. Tested Kingdom Hearts 2, Tales of Legendia and Gran Turismo 4 already (the latter two hit it)