Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GS/HW: Handle texture shuffles using region repeat (Ace Combat Series) #8826

Merged
merged 4 commits into from May 12, 2023
Merged

GS/HW: Handle texture shuffles using region repeat (Ace Combat Series) #8826

merged 4 commits into from May 12, 2023

Conversation

stenzek
Copy link
Member

@stenzek stenzek commented May 11, 2023 •
edited by lightningterror

Description of Changes

Ace Combat 04 reads RG, writes to RGBA by setting a MINU of 1015.

Rationale behind Changes

Fixes #1547.
Fixes #1739.
Fixes #1861.
Fixes #6626.

Untitled Untitled Untitled (clouds need CPU CLUT off, breaks them for some reason..)

Suggested Testing Steps

Test AC games.

@stenzek
GS/HW: Handle texture shuffles using region repeat
7184c34 
Ace Combat 04 reads RG, writes to RGBA by setting a MINU of 1015.
@stenzek stenzek changed the title GS/HW: Handle texture shuffles using region repeat GS/HW: Handle texture shuffles using region repeat (Ace Combat Series) May 11, 2023
@stenzek stenzek marked this pull request as draft May 11, 2023 13:29
@stenzek stenzek mentioned this pull request May 11, 2023
Closed
@stenzek stenzek marked this pull request as ready for review May 11, 2023 15:02
@lightningterror
Copy link
Contributor

Also fixes #6626 but will need high blending.

@JordanTheToaster
Copy link
Contributor

Requires native resolution and high blending upscaling breaks the effect.

image

@mirh
Copy link

mirh commented May 11, 2023 •
edited

It also seems to solve the other glitchy-but-not-totally-black issues.
Before:
Ace Combat 04 - Shattered Skies_SLUS-20152_20230512002441
Now:
Ace Combat 04 - Shattered Skies_SLUS-20152_20230512003123
Btw, not sure if it couldn't help with pinning down "repeated regions", trying to upscale this scene with merge sprite is absolute hell. EDIT: aka

@stenzek
Copy link
Member Author

stenzek commented May 12, 2023

Btw, not sure if it couldn't help with pinning down "repeated regions", trying to upscale this scene with merge sprite is absolute hell.

No, completely unrelated.

@refractionpcsx2 refractionpcsx2 merged commit 38480d3 into PCSX2:master May 12, 2023
11 checks passed
@MarcoEstevez
Copy link
Contributor

Just wanted to say thanks here, I though that issue would have never be resolved, I always played it on soft mode, or in the real console, but original resolution makes the terrain and enemies so blurry that it's hard to see anything, really thanks to all of you guys

@mirh mirh mentioned this pull request Sep 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mrlinkwii Mrlinkwii Mrlinkwii approved these changes

@JordanTheToaster JordanTheToaster JordanTheToaster approved these changes

Assignees
No one assigned
Labels
GS: Hardware GS: Texture Cache GS
Projects
None yet
Milestone
No milestone
7 participants
@stenzek @lightningterror @JordanTheToaster @mirh @MarcoEstevez @Mrlinkwii @refractionpcsx2