GS-TC: Fix bugs with target resize and borders in texture min max #8906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanTheToaster
approved these changes
May 30, 2023
Mrlinkwii
approved these changes
May 30, 2023
|
Breaks Test drive Eve of Destruction |
Could you elaborate further on how it breaks? |
|
Tried Test Drive - Eve of Destruction, menus are fine, did a race, that was all fine. I see no problems with it. If you're having issues, I suggest you visit the discord. |
|
v1.7.4541 works fine I just went back to it. Flickering was my problems in v1.7.4542. Menu's and even racing you can see flickering. |
|
@King27021 please use the discord/forums for support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fix some resizing bugs when tex is RT and it needs to resize the target, and don't resize when shuffles are involved.
Also fix an annoyance with texture min/max calculation.
Rationale behind Changes
The resizing was resizing down if it was reading strips of an RT but growing in the other direction, but also we weren't resizing if the BP's matched. Also if it was a shuffle/recursive draw there's no need to resize the texture (this breaks 50 Cent)
The scenario in Texture Min/Max was that it was doing a bilinear draw, so we add -0.5/0.5 to the coordinates to make sure we get whole pixels, however if the min X and Y was 0 they ended up as -1 (because we do floor(-0.5) on them, basically), causing the border check to think it was wrapping when this isn't the case.
Suggested Testing Steps
Just test an array of games, including the intro for Splinter Cell Pandora Tomorrow.
Dump runner showed a lot of differences again, however I think it was just reversing whatever happened in #8454 as they were all changes you couldn't really see.
Fixes Pandora Tomorrow intro screen.
Master:
PR:
