gsdx-ogl: accurate date regression. Bad interaction between depth & DATE #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need test of regression in others game (Shin Megami Tensei Nocturne, persona...) |
|
windows build for test http://bositman.pcsx2.net/gregory_pull_request/pcsx2-v1.3.1-1257-g588c0f0-windows-x86.7z |
|
Fixes the following bug report as mentioned by .r5 : http://forums.pcsx2.net/Thread-Bug-Report-OpenGL-Accurate-Date-Dragon-Ball-Z-Infinite-World-NTSC-U?page=2 |
In the DATE42 algo, first pass must find the primitive that write the bad alpha value. If depth test is fail, alpha value won't be written therefore you mustn't keep the primitive id. In theory to ensure 100% correctness, depth would need to be fully executed (currently depth write is disabled). However it requires to copy the depth buffer. It is likely bad for the perf. Issue reported on DBZInfWorld
gregory38
force-pushed
the
accurate-date-regression
branch
from
588c0f0
to
92553ad
Compare
gregory38
added a commit
that referenced
this pull request
Oct 22, 2015
gsdx-ogl: accurate date regression. Bad interaction between depth & DATE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the DATE42 algo, first pass must find the primitive that write the
bad alpha value. If depth test is fail, alpha value won't be written therefore
you mustn't keep the primitive id.
In theory to ensure 100% correctness, depth would need to be fully executed
(currently depth write is disabled). However it requires to copy the depth buffer.
It is likely bad for the perf.
Issue reported on DBZInfWorld