GS/Vulkan: Add missing chain to exclusive fullscreen control #8953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was adding additional padding, which blew the block size out.
github-actions
bot
added
GS
GS: Direct3D 11
GS: Direct3D 12
GS: OpenGL
GS: Vulkan
labels
|
Just did a quick test with Vulkan allowed exclusive fullscreen option, volume overlay is not visible. With disallowed, it shows volume overlay. So, it's all good to me. |
refractionpcsx2
approved these changes
Jun 10, 2023
JordanTheToaster
approved these changes
Jun 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Stops the validation layer complaining.
Other commit also fixes another validation layer error - it wasn't a real issue, since the padding never gets read, but nonetheless it's better to be correct.
Rationale behind Changes
Validation layer reports are there for a good reason.
Suggested Testing Steps
Make sure exclusive fullscreen control still works (i.e. allowed -> volume overlay is not visible).