GS/HW: Make Haunting Ground render fix invalidate depth as well #8978
Conversation
|
I tested it just now and while the depth leakage is fixed, the haunting ground logo appearing on screen after starting a new game still shows up, not sure if that'd need to be a different PR or not. Also by checking more scenes out, I found another bug possibly linked to the logo getting burned on screen but not sure, this one doesn't disappear after switching to software renderer and back so maybe is completely unrelated. In some scenes, (this case being "the great flood") this happens, not sure how to even explain it apart from "the screen is very white", it also occurs on the main build so it wasn't introduced by this PR. It feels like the game logo getting burned on screen after starting a new game imo (also still present) Here are gsdumps of both (the one for the white screen one I mentioned is a multi-frame gs dump, for some reason when making a single frame gsdump on that one it'd give me a corrupted archive) Thank you again for figuring out how to fix the depth leakage issue btw, that was fast, I really should've checked more cutscenes/gameplay before submitting the report, sorry. |
Fixes depth leaking into the image.
|
More pain in the ass stuff. It's nothing too complicated, just abusing GS local memory. All three dumps are fine now. If you open them, it'll flash the junk on the screen for a couple of frames - that's just due to the forced preload hack. Ingame should be fine. The proper solution, non-hacky to this requires my clear PR (#8961), as well as proper overlapping colour/depth targets in the TC (which I haven't done yet). |
|
Thank you so much! I've checked and all of the bugs I've mentioned are gone now. I also checked more stuff like the game over screen, other cutscenes, and even gameplay from different points and I can't find any other issues I think it should be all fine now! Thanks again! |
|
i play xbsx2 on xbox, how do i use them? |
Why are you asking us? If you're not aware, this fork violates our license, my own copyright, and abused several of our developers over the course of months last year, and our attempts to resolve it were met with silence and more crap-flinging. Please have the respect to not discuss it here, thanks. |
|
I'm so sorry my intentions weren't bad, if I've hurt you unintentionally,
I'd like to meet it.
16 Haz 2023 Cum 10:51 tarihinde Connor McLaughlin ***@***.***>
şunu yazdı:
… i play xbsx2 on xbox, how do i use them?
Why are you asking us? If you're not aware, this fork violates our
license, my own copyright, and abused several of our developers over the
course of months last year, and our attempts to resolve it were met with
silence and more crap-flinging.
Please have the respect to not discuss it here, thanks.
—
Reply to this email directly, view it on GitHub
<#8978 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BATSGN34Y6DOX5DM5IRLXOTXLQF7PANCNFSM6AAAAAAZGNH3IU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Description of Changes
Fixes depth leaking into the image.
Game's an ass. See the comment in the source.
Note to myself: my clear PR currently doesn't negate the need for this fix... need to dig further into why.
Rationale behind Changes
Closes #8976.
Suggested Testing Steps
Test Haunting Ground. The 3 dumps I have seem okay.