GS: Fix up overscan offsets. Stop using 3:2 for overscan. #8996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refractionpcsx2
force-pushed
the
gs_overscannumbers
branch
from
60bba43
to
951efac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes up the offsets for overscan modes and correctly stays in 4:3 when overscanning, closer matching the PS2
Rationale behind Changes
Numbers were quite a bit off, causing a weird vertical offset. and I don't know where I hit my head to think I needed to change aspect. Closer matches PS2 output now.
Suggested Testing Steps
None really, just PRing for the CI then merge, already gone through it on Discord with Nicknine.
Before:
After:
PS2 output through capture (with exagerated gamma/greenness so you can see the borders):
