Qt: Native DualShock 3 support in Windows using official Sony driver #9138

David-CPP · 2023-07-01T14:40:00Z

Description of Changes

Adds native DualShock 3 support in Windows to Qt PCSX2 using official Sony driver. An advantage this PR has over SDL is that rumble is supported.

I have created a new InputSource for DualShock 3 analogous to SDL/DirectInput/XInput.

I have implemented Automatic Mapping for convenience.

Credit to @rewasdadmin for implementing DualShock 3 native support in the old wxWidgets PCSX2 which I ported (#7099).

Rationale behind Changes

DualShock 3 rumble support is not provided by SDL.

Suggested Testing Steps

Test with multiple DualShock 3 controllers on a range of games. I have tested with the two DualShock 3 controllers I have and all seems well.

github-actions

Thank you for submitting a contribution to PCSX2

As this is your first pull request, please be aware of the contributing guidelines.

Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.

Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!

stenzek · 2023-07-01T15:02:21Z

Bit of a shame this can't be added to SDL instead, to avoid duplication.

AFAIK DS3 with pressure is supported under SDL on Linux.

seta-san · 2023-07-01T17:59:14Z

Bit of a shame this can't be added to SDL instead, to avoid duplication.

AFAIK DS3 with pressure is supported under SDL on Linux.

Is it a bug in sdl?

Bitwolfies · 2023-07-01T21:34:33Z

Bit of a shame this can't be added to SDL instead, to avoid duplication.

AFAIK DS3 with pressure is supported under SDL on Linux.

I assume the standard Linux DS3 driver supports rumble but not pressure? Any reason rumble cant be added to SDL's HIDAPI driver? Seems very odd.

David-CPP · 2023-07-01T22:58:47Z

Bit of a shame this can't be added to SDL instead, to avoid duplication.

I believe there is a limitation with the official Sony driver where you can't initialize HID Reports and this is why SDL do not have HID support for DualShock 3. See libsdl-org/SDL@1fc7f68

mirh · 2023-07-03T13:16:44Z

I'm sorry, what are we even talking about here?
There is *no* driver out of the box in Windows, that's what the unassuming note in the sources is saying. It's not just that HIDAPI doesn't work, everything is bust until you install sixaxis.sys, or dshidmini, or fireshock or SCP.
And as I moaned in libsdl-org/SDL#5148 (comment), SDL didn't care yet to support any of the specific windows solutions.

So.. uhm, whatever you are eventually using in your "vanilla SDL" scenario seems just directinput or xinput.

refractionpcsx2 · 2023-07-03T14:11:22Z

I'm sorry, what are we even talking about here? There is no driver out of the box in Windows, that's what the unassuming note in the sources is saying. It's not just that HIDAPI doesn't work, everything is bust until you install sixaxis.sys, or dshidmini, or fireshock or SCP. And as I moaned in libsdl-org/SDL#5148 (comment), SDL didn't care yet to support any of the specific windows solutions.

So.. uhm, whatever you are eventually using in your "vanilla SDL" scenario seems just directinput or xinput.

Nobody is saying it's out of the box, there is an official Sony driver for DS3. https://www.pcgamingwiki.com/wiki/Controller:DualShock_3#Wired_connection_-_official_drivers

mirh · 2023-07-03T14:49:04Z

Yes, I know.. I probably wrote a part of that page..
That's what shipped first in the ps3 sdk for ages, then came to notice of the wider world with its inclusion in the ps now client, and it's also known as sixaxis.sys.
Believing "the official Sony driver [...] can't initialize HID Reports" doesn't seem to have clear this detail though.

An advantage the native Sony driver has over SDL is that rumble is supported.

It's just not clear what OP is thinking here.
Unless they are comparing another device driver to it (which of course would be pretty nonsensical and confusing) of course "SDL" is inferior when they aren't supporting anything DS3-specific on windows.
Then, this is the first time I hear about rumble somehow being special (and it could be a bug on its own right?), but analog buttons are definitively not working too.

All this premised, good that the old wx code was ported here.. but as stenzek noted it would be even nicer if this could be addressed upstream.

David-CPP · 2023-07-03T17:28:56Z

An advantage the native Sony driver has over SDL is that rumble is supported.

It's just not clear what OP is thinking here.

The point I was making is that if you use a DS3 controller with Qt PCSX and select SDL input, you don't get rumble support. With my PR, which uses Windows HID API, if you have the Sony sixaxis.sys driver installed then rumble is supported. Edited to make it clearer.

mirh · 2023-07-03T22:02:26Z

Yes, but it just wasn't clear what kind of driver you were using with SDL.
Anyway, assuming it's still sixaxis.sys.. and assuming this isn't different for DS4, I seem to understand then force feedback just isn't exposed over DirectInput (I also just checked with rpcs3 and x360ce and the same happens).

So.. if nobody is adding this to SDL, I suppose this PR is the second best thing.

eVenent · 2023-07-03T22:53:08Z

Great job David! I was waiting for this since Qt has become official PCSX2 version. Finally I will be able to leave old wxWidgets build. I'm using official Sony's driver with RPCS3, DS4Windows and reWASD, so changing driver to unofficial one was not comfortable for me. This one I will be able to use with official DS3, virtual DS3 by reWASD and with adapter DS2 to DS3 and make my pressure-sensitive controllers work again with the newest version of PCSX2. I hoped that SDL will add this feature, but they skipped Windows version, so official driver is the most comfortable way to play with this controller. Thank you very much!

stenzek

CMakeLists also needs to be updated.

stenzek · 2023-07-04T07:45:38Z

pcsx2/Input/DualShock3InputSource.h

+		std::array<bool, 17> physicalButtonState = {}; 
+		std::array<bool, 17> lastPhysicalButtonState = {};
+
+		//If we wever want to support pressure sensitive buttons


Seems a bit silly to go to all the effort of adding a DS3-specific backend but not support pressure-sensitive buttons? Since that would be the main reason for using a DS3.

May as well just use DInput in that case.

stenzek · 2023-07-04T07:46:06Z

pcsx2/Input/DualShock3InputSource.h

+
+		bool active = false;
+
+		u8 SmallMotorOn = 0; // 0 or 1 (off/on)


Inconsistent variable naming. Try to use snake_case for all fields/local variables.

stenzek · 2023-07-04T07:46:30Z

pcsx2/Input/DualShock3InputSource.h

+	static constexpr u16 DS3_VID = 0x054c; // Sony Corp.
+	static constexpr u16 DS3_PID = 0x0268; // PlayStation 3 Controller
+
+	static constexpr const char* DualShock3AxisNames[] = {


All of these declarations should be in the .cpp file, not the .h.

stenzek · 2023-07-04T07:47:10Z

pcsx2/Input/WindowsHIDUtility.cpp

+
+namespace WindowsHIDUtility
+{
+	std::vector<HidDeviceInfo> FindHids(u16 vid, u16 pid)


This code isn't used anywhere else, and is probably unlikely to be, so it's best to make it local to the DS3 input source, rather than adding additional files.

stenzek · 2023-07-04T07:48:02Z

pcsx2/Input/WindowsHIDUtility.cpp

+				if (GetLastError() != ERROR_INSUFFICIENT_BUFFER || !size)
+					continue;
+
+				SP_DEVICE_INTERFACE_DETAIL_DATA_W* devInterfaceDetails = (SP_DEVICE_INTERFACE_DETAIL_DATA_W*)malloc(size);


Use a unique_ptr, not C malloc/free. You're leaking memory with the continues otherwise.

stenzek · 2023-07-04T07:48:18Z

pcsx2/Input/WindowsHIDUtility.cpp

+				{
+					HIDD_ATTRIBUTES attributes;
+					attributes.Size = sizeof(attributes);
+					if (HidD_GetAttributes(hfile, &attributes))


Better to use continue here rather than a staircase of ifs.

stenzek · 2023-07-04T07:48:59Z

pcsx2/Input/WindowsHIDUtility.cpp

+{
+	std::vector<HidDeviceInfo> FindHids(u16 vid, u16 pid)
+	{
+		std::vector<HidDeviceInfo> foundDevs;


See variable naming note above.

stenzek · 2023-07-04T07:50:29Z

pcsx2/Input/DualShock3InputSource.h

+
+	public:		
+		bool Activate();
+		void Deactivate();


A destructor is better than an explicit "Deactivate()" call.

stenzek · 2023-07-04T07:52:59Z

As I noted in the review above, this doesn't seem to actually report pressure sensitivity, so I'm questioning what the point is in its current state.

mirh · 2023-07-04T12:53:21Z

As noted above, adding rumble is already a pretty important addition.
On the other hand it seems odd to claim to be porting something, while missing some of its features.

And if you are still going to have a subpar experience, than at this point you could as well just recommend dshidmini isn't it?

David-CPP · 2023-07-04T13:38:42Z

Thanks for the feedback. I'll look into implementing pressure-sensitive buttons.

diego-rbb-93 · 2024-01-22T09:55:56Z

Thanks for the feedback. I'll look into implementing pressure-sensitive buttons.

Sorry to bump this up, but I've been recently catching some new DS3 controllers to test this out in the future but, are you managing to finish the PR?

Qt: Native DualShock 3 support in Windows using official Sony driver

577cbcb

github-actions bot added Build | Project System GUI/Qt First Time Contribution labels Jul 1, 2023

github-actions bot reviewed Jul 1, 2023

View reviewed changes

stenzek requested changes Jul 4, 2023

View reviewed changes

xTVaser mentioned this pull request Jul 24, 2023

Pressure Sensitive button support open-goal/jak-project#2773

Closed

lightningterror added the Needs Rebase label Sep 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Qt: Native DualShock 3 support in Windows using official Sony driver #9138

Qt: Native DualShock 3 support in Windows using official Sony driver #9138

David-CPP commented Jul 1, 2023 •

edited

github-actions bot left a comment

stenzek commented Jul 1, 2023

seta-san commented Jul 1, 2023

Bitwolfies commented Jul 1, 2023

David-CPP commented Jul 1, 2023

mirh commented Jul 3, 2023

refractionpcsx2 commented Jul 3, 2023

mirh commented Jul 3, 2023 •

edited

David-CPP commented Jul 3, 2023 •

edited

mirh commented Jul 3, 2023

eVenent commented Jul 3, 2023

stenzek left a comment

stenzek Jul 4, 2023

stenzek Jul 4, 2023

stenzek Jul 4, 2023

stenzek Jul 4, 2023

stenzek Jul 4, 2023

stenzek Jul 4, 2023

stenzek Jul 4, 2023

stenzek Jul 4, 2023

stenzek commented Jul 4, 2023

mirh commented Jul 4, 2023 •

edited

David-CPP commented Jul 4, 2023

diego-rbb-93 commented Jan 22, 2024

Qt: Native DualShock 3 support in Windows using official Sony driver #9138

Are you sure you want to change the base?

Qt: Native DualShock 3 support in Windows using official Sony driver #9138

Conversation

David-CPP commented Jul 1, 2023 • edited

Description of Changes

Rationale behind Changes

Suggested Testing Steps

github-actions bot left a comment

Choose a reason for hiding this comment

Thank you for submitting a contribution to PCSX2

stenzek commented Jul 1, 2023

seta-san commented Jul 1, 2023

Bitwolfies commented Jul 1, 2023

David-CPP commented Jul 1, 2023

mirh commented Jul 3, 2023

refractionpcsx2 commented Jul 3, 2023

mirh commented Jul 3, 2023 • edited

David-CPP commented Jul 3, 2023 • edited

mirh commented Jul 3, 2023

eVenent commented Jul 3, 2023

stenzek left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stenzek commented Jul 4, 2023

mirh commented Jul 4, 2023 • edited

David-CPP commented Jul 4, 2023

diego-rbb-93 commented Jan 22, 2024

David-CPP commented Jul 1, 2023 •

edited

mirh commented Jul 3, 2023 •

edited

David-CPP commented Jul 3, 2023 •

edited

mirh commented Jul 4, 2023 •

edited