USB: Fix DJ Hero Turntable Labels #9183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjay900
force-pushed
the
master
branch
2 times, most recently
from
7e90513
to
ca4a38f
Compare
stenzek
reviewed
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Update some of the labels used for DJ Hero Turntable Emulation
Swap the multiplier from integer to float
Fix turntables being scaled by 255 instead of 128
Rationale behind Changes
A few people contacted me on one of the DJ Hero Discord servers and pointed out that the labels I had used were somewhat confusing and in a few places they were actually wrong.
I have gone for clockwise and counterclockwise, as the turntables can be in any orientation, and due to that it is possible for up and down to be a bit confusing in different orientations.
Someone also tested with a Wii Turntable with a Raphnet adapter, and it turns out those need to be given a fractional multiplier, as the turntable range from those is too large and the game doesn't handle it correctly.
Since the positive and negative values are bound seperately, the turntable needs to be scaled by 128 not 255
Suggested Testing Steps
Turn on DJ Hero Turntable emulation and look at the clarified labels, and confirm that the multiplier is now float and not integer.