Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GS-ogl: Fixes Wunused-but-set-variable warning. #9203

Merged
merged 1 commit into from
Jul 10, 2023
Merged

GS-ogl: Fixes Wunused-but-set-variable warning. #9203

merged 1 commit into from
Jul 10, 2023

Conversation

lightningterror
Copy link
Contributor

@lightningterror lightningterror commented Jul 9, 2023 •
edited

Description of Changes

Fixes Wunused-but-set-variable warning.

Rationale behind Changes

Cleanup warnings.

Suggested Testing Steps

CI passes.

stenzek
stenzek requested changes Jul 9, 2023
View reviewed changes
Copy link
Member

@stenzek stenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove this, it is useful for support (specifically grepping).

Don't remove the Intel check either (it may be useful in the future), silence the warning instead.

@lightningterror
Gs-ogl: Comment out intel vendor set.
cbad9eb 
Fixes Wunused-but-set-variable warning.
@lightningterror lightningterror changed the title GS-ogl: Cleanup CheckFeatures. GS-ogl: Fixes Wunused-but-set-variable warning. Jul 9, 2023
stenzek
stenzek approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@stenzek stenzek left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer nabbing the warning with (void)vendor_id_intel; or something ([[maybe_unused]] might work here too), but this'll do for now.

@lightningterror lightningterror merged commit 4ded2ca into master Jul 10, 2023
22 checks passed
@lightningterror lightningterror deleted the gs_gl_vendor branch July 10, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stenzek stenzek stenzek approved these changes

Assignees
No one assigned
Labels
GS: OpenGL GS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lightningterror @stenzek