Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS/HW: Support alpha in RT concurrently with Z #9251

Merged
merged 2 commits into from Jul 20, 2023
Merged

Conversation

stenzek
Copy link
Member

@stenzek stenzek commented Jul 15, 2023

Description of Changes

Currently, PCSX2 removes any Z targets when you write to the RT at an address, or vice versa. Hence the gross CRC hack for Getaway. Let's get rid of that, which also fixes a bunch of other issues.

  • Fixes lens flare and DoF in True Crime: NYC.
  • Fixes reflections in Eragon.
  • Fixes floor in Area 51.
  • Fixes flickering in Transformers.
  • Improves fog effect in Forgotten Realms - Demon Stone.

Rationale behind Changes

Fixes lens flare noted in #8242.
Gets rid of 1/4 of the remaining GSCrc entries.
Fixes #3986.

Suggested Testing Steps

Test affected games.
Make sure DBZ BT2/3 didn't take a non-trivial speed hit.

Changes (before, after)

image
image

image
image

(needs high blending for fog wall)
image
image

image
image

image
image

@F0bes
Copy link
Member

F0bes commented Jul 15, 2023

@kamfretoz
Copy link
Contributor

Can someone check if this issue is fixed as well?

image

@stenzek
Copy link
Member Author

stenzek commented Jul 15, 2023

Smells like an invalidation issue, it should be reading from local memory, not the FB.

@kamfretoz
Copy link
Contributor

kamfretoz commented Jul 15, 2023

Smells like an invalidation issue, it should be reading from local memory, not the FB.

Is it similar/related to #9004 ?

@stenzek
Copy link
Member Author

stenzek commented Jul 15, 2023

Keroro's a bit more complex (target size/format changes, I forget which), but at a high level, yes.

@refractionpcsx2
Copy link
Member

Keroro's a bit more complex (target size/format changes, I forget which), but at a high level, yes.

yeah they change the width of the FB with the font in the alpha (still at the old width)

@stenzek stenzek force-pushed the rt-and-ds branch 2 times, most recently from 01e5c07 to 63822c0 Compare July 16, 2023 10:05
@stenzek stenzek marked this pull request as draft July 16, 2023 13:34
Also further improve double half clear detection, and handling of
horizontal page clears.

Fixes lens flare and DoF in True Crime: NYC.
Fixes reflections in Eragon.
Fixes floor in Area 51.
Fixes flickering in Transformers.
Fixes text in Katamari Damashii.
@stenzek stenzek marked this pull request as ready for review July 18, 2023 13:22
@stenzek
Copy link
Member Author

stenzek commented Jul 18, 2023

Rebased, all known regressions fixed.

@JordanTheToaster
Copy link
Contributor

JordanTheToaster commented Jul 19, 2023

Fixes DBZ BT3 depth garbage.
BestGame.zip

Master:
image

PR:
image

@lightningterror
Copy link
Contributor

And how did it look before?

@JordanTheToaster
Copy link
Contributor

And how did it look before?

Updated now with pictures.

@stenzek stenzek merged commit c72329d into PCSX2:master Jul 20, 2023
13 checks passed
@stenzek stenzek deleted the rt-and-ds branch July 20, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] The Getaway - shadows broken due to InvalidateVideoMemType
6 participants