Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EE: Prevent usage of uninitialized scalar variable #944

Merged
merged 1 commit into from
Oct 31, 2015

Conversation

ssakash
Copy link
Member

@ssakash ssakash commented Oct 31, 2015

Quick fix for the following issues,

  • CID 153601 (Initial debugger work #1 of 1): Uninitialized scalar variable (UNINIT)7. uninit_use: Using uninitialized value scalarHigh.
  • CID 153602 (Initial debugger work #1 of 1): Uninitialized scalar variable (UNINIT)7. uninit_use: Using uninitialized value scalarLow.
  • CID 153603 (Initial debugger work #1 of 1): Uninitialized scalar variable (UNINIT)7. uninit_use: Using uninitialized value scalarMid.

Summary of changes:-

  • Remove a duplicated check EmuConfig.Speedhacks.EECycleRate == 0 since the check will eventually be done on the switch case statement.
  • Prevent a chance for uninitialized variable usage when users set more than 100 in INI file.

actually I thought of fixing these issues at the next update to the overclock function but that would probably take some time so did the fixes now :) , Thanks to @gregory38 for finding the issue.

Fixes CID 153601 , CID 153602 , CID 153603
ramapcsx2 added a commit that referenced this pull request Oct 31, 2015
EE: Prevent usage of uninitialized scalar variable
@ramapcsx2 ramapcsx2 merged commit 49688e2 into PCSX2:master Oct 31, 2015
@ssakash ssakash deleted the coverity_EE branch October 31, 2015 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants