RetroAchievements/Qt: Add configurable achievement notification duration #9722
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for submitting a contribution to PCSX2
As this is your first pull request, please be aware of the contributing guidelines.
Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.
Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!
|
you forgot to mention fixes #9692 |
I knew I'd forget it, thanks! |
TwosomesUP
force-pushed
the
ra-achievement-notifications
branch
from
28c181b
to
db75bf6
Compare
|
Looking into MacOS and Linux build issues and will test in my fork. I'm not too familiar with either OS so it may take some tinkering. XD Edit: Found the issue. Luckily it was an easy fix. MacOS and Linux build checks seem to be passing now. |
TwosomesUP
force-pushed
the
ra-achievement-notifications
branch
from
d09c184
to
0d16f7f
Compare
Description of Changes
This change adds a configurable duration for the Retro Achievements notifications. This PR also includes a minor update to the the BindSliderToIntSetting method to allow clamping of values when binding a slider to a setting in case of manual updates.
Fixes issue #9692
Rationale behind Changes
Long durations on notifications can be intrusive to gameplay. This allows players to modify notification durations to their preference.
Suggested Testing Steps
This PR affects all achievement notifications so the configured duration can be observed during the initial game info notification, when mastering a game, when unlocking an achievement, and when activating/submitting a leaderboard.
Game used for testing was Kuon (SLUS-21007). If using the attached save state, you can just open the door in front of the character to unlock an achievement.
SLUS-21007 (9AC63A2E).01.zip
Considerations
If needed, or wanted, individual duration sliders for each type of notification (achievement unlock, mastery, leaderboard, etc) can be added.