Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkeys: Add "Toggle On-Screen Display" #9860

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Hotkeys: Add "Toggle On-Screen Display" #9860

merged 1 commit into from
Aug 27, 2023

Conversation

stenzek
Copy link
Member

@stenzek stenzek commented Aug 26, 2023

Description of Changes

Toggles whatever's enabled on and off.

Rationale behind Changes

Closes #9683.

Suggested Testing Steps

Test new hotkey.

@github-actions github-actions bot added the GS label Aug 26, 2023
@bigol83
Copy link

bigol83 commented Aug 26, 2023

Just checked it and it works great, It applies to general OSD settings and even game profile OSD settings. Tried with DS4 assigning toggle to touchpad, it's really cool right now.

One minor error though: when i extracted the build and clicked on pcsx2.clang to run setup wizard i had this issue

error

Since my language is set to System language (Italian), i don't know if it's something specific to Italian language or to any other translated languages.

Anyway, after i click OK, setup works as expected even in Italian language and there are no other errors using the emulator.

@stenzek
Copy link
Member Author

stenzek commented Aug 27, 2023

One minor error though: when i extracted the build and clicked on pcsx2.clang to run setup wizard i had this issue

That'll happen if you use the MSBuild binaries, not the CMake binaries. MSBuild doesn't merge the base translation modules into one file. Been on my todo list for a while, but because we only distribute CMake builds as releases, it's kinda a non-issue.

@stenzek stenzek merged commit 62c6743 into PCSX2:master Aug 27, 2023
12 checks passed
@stenzek stenzek deleted the osd branch August 27, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add customizable hotkey to quickly enable/disable OSD.
3 participants